feat: added quantile function (new) #23580

jaskiratsingh2000 · 2023-09-14T06:16:04Z

Close #19176

github-actions

PR Compliance Checks Passed!

jaskiratsingh2000 · 2023-09-14T06:17:19Z

@lucasalavapena - Please review this

ivy-leaves · 2023-09-14T06:30:03Z

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

jaskiratsingh2000 · 2023-09-14T06:53:27Z

@lucasalavapena This is the infor from Github-bot on many PRs so I want to highlight as it says we can "ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀" which means it is good to go. Please let me know.

`Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:

Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:

Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪

The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻`

lucasalavapena · 2023-09-14T08:29:28Z

@lucasalavapena This is the infor from Github-bot on many PRs so I want to highlight as it says we can "ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀" which means it is good to go. Please let me know.

`Thanks for contributing to Ivy! 😊👏 Here are some of the important points from our Contributing Guidelines 📝:

Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:

Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️

New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪

The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧

Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻`

You have to click on the details and actually look at the results. They are still failing...

a0m0rajab · 2023-09-14T08:30:34Z

@jaskiratsingh2000 hi thank you for mentioning the bot, the idea of that message meant to go directly to combined tests instead of checking each of them which we updated the message on last bot and removed it though. PLus, could you add a closing word to the PR reference? it would help to connect it with the issue and auto-close it,

lucasalavapena · 2023-09-14T08:35:18Z

#10704

You are linking the wrong issue? That is for backends. You are adding a frontend. Plus you should link the quantile
individual frontend issue not the master issue for all frontends/backends

jaskiratsingh2000 · 2023-09-14T08:36:01Z

@lucasalavapena I actually tried but unabel to resolve them at my end. I did actually what I could do during debugs. Would appreciate if locally you cancpush them up once?

jaskiratsingh2000 · 2023-09-14T08:39:50Z

@lucasalavapena Apology in that part here is the master issue - #15045
and this one is sub-task #19176

lucasalavapena · 2023-09-14T08:50:20Z

@lucasalavapena I actually tried but unabel to resolve them at my end. I did actually what I could do during debugs. Would appreciate if locally you cancpush them up once?

All I did was make the axis into an int in your test

jaskiratsingh2000 · 2023-09-14T08:53:02Z

@lucasalavapena you mean where I refer to axis=axis that should be made to axis=int. right?

lucasalavapena · 2023-09-14T09:06:38Z

@lucasalavapena you mean where I refer to axis=axis that should be made to axis=int. right?

No, I explained this better in the other PR in which I showed you part of the paddle paddle code. Your axis variable during tests was sometimes (0,) and other times 0, and I have shown you multiple times now that paddle does not take a tuple as an input for axis

lucasalavapena · 2023-09-14T09:07:25Z

@lucasalavapena Apology in that part here is the master issue - #15045 and this one is sub-task #19176

Thanks for letting me know 😄 . I updated your first PR comment so it should be all good, please do that next time or update any existing PR you may have accordingly!

jaskiratsingh2000 · 2023-09-14T09:07:59Z

@lucasalavapena I made the axis variable as an int itself in the test.

jaskiratsingh2000 · 2023-09-14T09:15:14Z

@lucasalavapena or the another opotion that can be done is

dtype_x_and_axis=helpers.dtype_values_axis(
        available_dtypes=helpers.get_dtypes("valid"),
        min_num_dims=1,
        min_value=-1e10,
        max_value=1e10,
        valid_axis=True,
        force_int_axis=True,  # Assuming this forces the axis to be an integer.
    )

jaskiratsingh2000 · 2023-09-14T09:27:35Z

@lucasalavapena I tried adding what I mentioned to you on Discord. but there is no luck in surpassing those checks. I'm not able to debug this further. Therefore, I have also raised the concern on Discord Testing channel but there have been no response from them so far. Please, would really appreciate if you could over-commit on my previous or let me know what change I should made it now?
Thanks!
@lucasalavapena

jaskiratsingh2000 · 2023-09-14T15:19:22Z

@lucasalavapena As you mentioned that you were able to make a change and run the test case can you just tell me where exactly made the change? I'm struggling with that even after debugging. and I feel this is at the last stage. Please let me know if you can this would really means a lot.

jaskiratsingh2000 · 2023-09-14T18:18:21Z

@Ishticode @lucasalavapena Please please let me know on this.

jaskiratsingh2000 · 2023-09-15T07:12:17Z

@lucasalavapena I'm getting this error which I'm unable to understand thouh I know it is an issue of module imports but how to solve it?

Traceback (most recent call last):
  File "/Users/jaskiratsingh/ivy/ivy_tests/test_ivy/test_frontends/test_paddle/test_stat.py", line 5, in <module>
    import ivy_tests.test_ivy.helpers as helpers
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/__init__.py", line 2, in <module>
    from . import hypothesis_helpers
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/hypothesis_helpers/__init__.py", line 1, in <module>
    from . import general_helpers
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/hypothesis_helpers/general_helpers.py", line 9, in <module>
    from . import array_helpers, number_helpers, dtype_helpers
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/hypothesis_helpers/array_helpers.py", line 16, in <module>
    from ivy_tests.test_ivy.helpers.hypothesis_helpers.dtype_helpers import get_dtypes
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/hypothesis_helpers/dtype_helpers.py", line 14, in <module>
    from ...conftest import mod_backend
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/conftest.py", line 37, in <module>
    from ivy_tests.test_ivy.helpers.multiprocessing import backend_proc, frontend_proc
  File "/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/multiprocessing.py", line 5, in <module>
    from ivy_tests.test_ivy.helpers.hypothesis_helpers.array_helpers import (
ImportError: cannot import name 'array_helpers_dtype_info_helper' from partially initialized module 'ivy_tests.test_ivy.helpers.hypothesis_helpers.array_helpers' (most likely due to a circular import) (/Users/jaskiratsingh/opt/anaconda3/envs/ivy_dev/lib/python3.10/site-packages/ivy_tests/test_ivy/helpers/hypothesis_helpers/array_helpers.py)

Sarvesh-Kesharwani · 2023-09-15T18:27:43Z

ivy_tests/test_ivy/test_frontends/test_paddle/test_stat.py

+    input_dtypes, (x,), axis = dtype_x_and_axis
+    # Convert axis if it's a tuple
+    if isinstance(axis, tuple):
+        axis = axis[0] if len(axis) == 1 else list(axis)


what's the purpose of this logic, I don't think this is required.

Since axis varibale has to be int not tuples when accepting parameters so that is wy I added it.

ivy/functional/frontends/paddle/stat.py

Sarvesh-Kesharwani · 2023-09-15T18:29:43Z

ivy/functional/frontends/paddle/stat.py

+)
+@to_ivy_arrays_and_back
+def quantile(x, q, axis=None, keepdim=False):
+    return ivy.quantile(x, q, axis=axis, keepdims=keepdim)


Paddle quantile returns float64 to obtain higher precision.

So should I mention only float64?

It's not fixed "AssertionError: returned dtype = float32, ground-truth returned dtype = float64"
this is not related to the supported dtypes but the return dtype of the function

@Sarvesh-Kesharwani This has to be implemented within the Test file or this one?

@Sarvesh-Kesharwani I have added. Can you check?

Sarvesh-Kesharwani · 2023-09-15T18:56:47Z

you need to fix the lint errors as well.

jaskiratsingh2000 · 2023-09-15T19:09:17Z

@Sarvesh-Kesharwani lint error is resolved and the changes you requested I made. Still I feel these tests cases fail. Not sure why and how to resolve them

Sarvesh-Kesharwani · 2023-09-16T07:42:49Z

Plus there is a shape mismatch error as well, you need to update your function logic to return the shape which matches the ground_truth shape

jaskiratsingh2000 · 2023-09-16T07:47:38Z

@Sarvesh-Kesharwani could you please let me know that error seems to be within the test file or another file?

Looking forward to hearing from you.

Thanks, and Regards

jaskiratsingh2000 · 2023-09-16T08:50:22Z

@Sarvesh-Kesharwani I have resolve the both the errors which you mentioned to nme. Can you please review it again?

ivy-seed · 2024-01-07T05:53:38Z

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed · 2024-02-17T05:53:38Z

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

jaskiratsingh2000 added 2 commits September 14, 2023 11:38

feat: added quantile function (new)

6554a6d

Updated test_stat.py

cdf7281

github-actions bot reviewed Sep 14, 2023

View reviewed changes

jaskiratsingh2000 mentioned this pull request Sep 14, 2023

feat: added quantile function #23558

Closed

ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 14, 2023

ivy-seed assigned Ishticode Sep 14, 2023

lucasalavapena self-assigned this Sep 14, 2023

jaskiratsingh2000 added 2 commits September 14, 2023 14:24

Update test_stat.py

e47a288

Update test_stat.py

bb41410

Update test_stat.py

421236d

a0m0rajab modified the milestone: #10388 Sep 14, 2023

Update test_stat.py

d17d170

jaskiratsingh2000 added 6 commits September 15, 2023 13:58

Update test_stat.py (added helper function)

720c562

Update test_stat.py

45aa5ce

Update test_stat.py

5994d02

Update test_stat.py

8ed7ed1

Update test_stat.py (original)

82ec8db

Update test_stat.py

fe9631a

Sarvesh-Kesharwani reviewed Sep 15, 2023

View reviewed changes

ivy/functional/frontends/paddle/stat.py Outdated Show resolved Hide resolved

Sarvesh-Kesharwani reviewed Sep 15, 2023

View reviewed changes

Update stat.py

e282b46

Update test_stat.py (solved lint error)

a5287a5

jaskiratsingh2000 requested a review from Sarvesh-Kesharwani September 15, 2023 19:00

Update test_stat.py

9301adf

jaskiratsingh2000 added 3 commits September 16, 2023 13:49

Added "float64"

b7f0bfa

Added for lint

32fbc42

added shape fix

58187ec

Update stat.py

d3c42f5

Ishticode removed their assignment Oct 4, 2023

ivy-leaves unassigned lucasalavapena Dec 23, 2023

ivy-seed assigned joaozenobio Dec 24, 2023

ivy-seed added the Stale label Jan 7, 2024

ivy-seed closed this Feb 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added quantile function (new) #23580

feat: added quantile function (new) #23580

jaskiratsingh2000 commented Sep 14, 2023 •

edited by lucasalavapena

Loading

github-actions bot left a comment •

edited

Loading

jaskiratsingh2000 commented Sep 14, 2023

ivy-leaves commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

a0m0rajab commented Sep 14, 2023 •

edited

Loading

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 15, 2023

Sarvesh-Kesharwani Sep 15, 2023

jaskiratsingh2000 Sep 15, 2023 •

edited

Loading

Sarvesh-Kesharwani Sep 15, 2023

jaskiratsingh2000 Sep 15, 2023

Sarvesh-Kesharwani Sep 16, 2023 •

edited

Loading

jaskiratsingh2000 Sep 16, 2023

jaskiratsingh2000 Sep 16, 2023

Sarvesh-Kesharwani commented Sep 15, 2023

jaskiratsingh2000 commented Sep 15, 2023

Sarvesh-Kesharwani commented Sep 16, 2023

jaskiratsingh2000 commented Sep 16, 2023

jaskiratsingh2000 commented Sep 16, 2023

ivy-seed commented Jan 7, 2024

ivy-seed commented Feb 17, 2024

feat: added quantile function (new) #23580

feat: added quantile function (new) #23580

Conversation

jaskiratsingh2000 commented Sep 14, 2023 • edited by lucasalavapena Loading

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

jaskiratsingh2000 commented Sep 14, 2023

ivy-leaves commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

a0m0rajab commented Sep 14, 2023 • edited Loading

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

lucasalavapena commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 14, 2023

jaskiratsingh2000 commented Sep 15, 2023

Sarvesh-Kesharwani Sep 15, 2023

Choose a reason for hiding this comment

jaskiratsingh2000 Sep 15, 2023 • edited Loading

Choose a reason for hiding this comment

Sarvesh-Kesharwani Sep 15, 2023

Choose a reason for hiding this comment

jaskiratsingh2000 Sep 15, 2023

Choose a reason for hiding this comment

Sarvesh-Kesharwani Sep 16, 2023 • edited Loading

Choose a reason for hiding this comment

jaskiratsingh2000 Sep 16, 2023

Choose a reason for hiding this comment

jaskiratsingh2000 Sep 16, 2023

Choose a reason for hiding this comment

Sarvesh-Kesharwani commented Sep 15, 2023

jaskiratsingh2000 commented Sep 15, 2023

Sarvesh-Kesharwani commented Sep 16, 2023

jaskiratsingh2000 commented Sep 16, 2023

jaskiratsingh2000 commented Sep 16, 2023

ivy-seed commented Jan 7, 2024

ivy-seed commented Feb 17, 2024

jaskiratsingh2000 commented Sep 14, 2023 •

edited by lucasalavapena

Loading

github-actions bot left a comment •

edited

Loading

a0m0rajab commented Sep 14, 2023 •

edited

Loading

jaskiratsingh2000 Sep 15, 2023 •

edited

Loading

Sarvesh-Kesharwani Sep 16, 2023 •

edited

Loading