Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paddle.nanmedian frontend function #23578

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Mghrabi
Copy link
Contributor

@Mghrabi Mghrabi commented Sep 14, 2023

Fixes #24302

PR Description

  • Replaced ivy.median with ivy.nanmedian
  • Removed the dtype conversion since according to documentation here the returned dtype is the same of given input x.
  • Updated supported dtypes according to documentation as well.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@Mghrabi Mghrabi changed the title corrected the ivy function to be called (ivy.nanmedian) and dtypes fix paddle.nanmedian frontend function Sep 14, 2023
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 14, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@a0m0rajab a0m0rajab modified the milestone: #10388 Sep 14, 2023
@mohame54
Copy link
Contributor

Looks good to me.

@mohame54 mohame54 merged commit cc0e4ea into ivy-llc:main Sep 18, 2023
128 of 135 checks passed
@Mghrabi Mghrabi deleted the fix_paddle_nanmedian branch September 19, 2023 18:49
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix stat.test_paddle_nanmedian
4 participants