feat(paddle): Add frontend index_sample to search.py #23562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ILB-96
changed the title
ivy-leaves
added
the
Paddle Frontend
a0m0rajab
changed the title
|
Hi @Hazannovich thank you for the PR, I just changed the title and removed a space at the beginning of it, which caused the semantic checks to fail. Thank you for contributing to ivy though! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
YushaArif99
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Apologies for the previous comments. It turns out I was reviewing the wrong function here 😂. I thought this PR was implementing paddle.index_select which is slightly different from paddle.index_sample (which is what the PR is actually implementing).
With this out of the way, the changes look good to me. All relevant tests are also passing so I'll be going ahead with the merge 👍🏼
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Related Issue
23165
Close #23165
Checklist
Socials: