Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paddle): Add backward method to Paddle Frontend #23549

Closed
wants to merge 8 commits into from
Closed

feat(paddle): Add backward method to Paddle Frontend #23549

wants to merge 8 commits into from

Conversation

Boghdady9
Copy link
Contributor

PR Description

Add backward method to Paddle Frontend

Related Issue

Close #23407

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 13, 2023
@Boghdady9
Copy link
Contributor Author

@AnnaTz
I'm sorry for closing the last PR, but I encountered a conflict issue, so I closed it...

here, I made little changes and I tested the function on my machine before commit it, it passed all tests after many trails. I hope no more changes😁😅

@AnnaTz
Copy link
Contributor

AnnaTz commented Sep 14, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes before we merge :)

available_dtypes=helpers.get_dtypes("float"),
),
)
def test_paddle_backward(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the test to test_paddle_tensor_backward to be in line with our naming convention.

):
input_dtype, x = dtype_and_x
x = Tensor(x)
helpers.test_frontend_method(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x = Tensor(x) should not be needed here. I believe this is done inside test_frontend_method later on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnaTz
I passed the five tests only after I add x = Tensor(x), so I think it’s necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backward
5 participants