-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paddle): Add backward method to Paddle Frontend #23549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
@AnnaTz here, I made little changes and I tested the function on my machine before commit it, it passed all tests after many trails. I hope no more changes😁😅 |
ivy-gardener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor changes before we merge :)
available_dtypes=helpers.get_dtypes("float"), | ||
), | ||
) | ||
def test_paddle_backward( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the test to test_paddle_tensor_backward
to be in line with our naming convention.
): | ||
input_dtype, x = dtype_and_x | ||
x = Tensor(x) | ||
helpers.test_frontend_method( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x = Tensor(x)
should not be needed here. I believe this is done inside test_frontend_method
later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnnaTz
I passed the five tests only after I add x = Tensor(x), so I think it’s necessary
PR Description
Add backward method to Paddle Frontend
Related Issue
Close #23407
Checklist
Socials: