fix(ivy/functional): update diagflat docstring #23342
Conversation
…y-contribution#3
…nto Doc-opentask
| :func:`ivy.inplace_update` is a *primary* function, and the backend-specific implementations for each backend are presented below. | ||
| We also explain the rationale for why each implementation is the way it is, and the important differences. | ||
| We also explain the rational for why each implementation is the way it is, and the important differences. |
There was a problem hiding this comment.
this is wrong, similarly in many other places. Please fix/remove these erroneous grammatical changes.
| @@ -460,15 +464,15 @@ More information about these arrays can be found in `NumPy's documentation <http | |||
| This essentially means that any inplace update on the original array or any of its views will cause all the other views to be updated as well since they reference the same memory buffer. | |||
|
|
|||
| We want to keep supporting NumPy and PyTorch inplace updates whenever we can and superset backend behaviour, however it is not trivial to replicate this in JAX and TensorFlow. | |||
| The main reason is because these frameworks do not natively support inplace updates so even if multiple native arrays are referencing the same memory buffer, you would never be able to update it once for all of them. | |||
| The main reason is because these frameworks do not natively support inplace updates so even if multiple native arrays are referencing the same memory buffer, you would ever be able to update it once for all of them. | |||
There was a problem hiding this comment.
same here, this seems to a wrong fix. There are many such cases in the PR.
Hi @vaithak, I actually have no idea. All I changed was one file, and after creating a pull request, some of the files are getting changed. All I changed was update diagflat docstring in ivy\functional\ivy\experimental\linear_algebra.py file. Yeah now it is solved i guess |
…into ivy-functional
|
@YushaArif99 |
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
Description
In this updated docstring:
Related Issue
Close #17543
Checklist
ivy.diagflat()to accurately reflect the function's parameters and behavior.Socials:
N/A