Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added count_nonzero to paddle_frontend #23282

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

AryanSharma21
Copy link
Contributor

close #23118

Local env Function test result:

Screenshot 2023-09-07 at 10 26 52 AM

Local env lint formatting test:

Screenshot 2023-09-08 at 8 58 35 PM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 8, 2023
@AryanSharma21
Copy link
Contributor Author

Please review here @danielmunioz

Copy link
Contributor

@Daniel4078 Daniel4078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danielmunioz
Copy link
Contributor

Hey @AryanSharma21! Thanks for contributing!

Yeah the tests seem to be passing locally no problem there, however it seems that the function arguments are a bit different from the ones used on the original implementation could you please modify the arguments so that they match the original ones?

Other than that the PR looks in good shape!
Thanks! :)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@AryanSharma21
Copy link
Contributor Author

Hello @danielmunioz , thanks for pointing this out. I have removed the dtype argument here and re-tested, Is there anything else that needs to be fixed please let me know.

@danielmunioz
Copy link
Contributor

danielmunioz commented Sep 15, 2023

Hey! @AryanSharma21! Yeah, looks good now, just a minor extra letter on keepdims, paddle uses keepdim instead, but no worries, I'll take care of that little thing!

Other than that, the PR looks good to me!
Merging now! 🚀

Thanks for contributing :)

@danielmunioz danielmunioz merged commit 9a36235 into ivy-llc:main Sep 15, 2023
34 of 38 checks passed
@AryanSharma21 AryanSharma21 deleted the paddle_frontend branch September 17, 2023 05:44
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
Co-authored-by: Aryan Sharma <[email protected]>
Co-authored-by: danielmunioz <[email protected]>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored-by: Aryan Sharma <[email protected]>
Co-authored-by: danielmunioz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count_nonzero
4 participants