-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added count_nonzero to paddle_frontend #23282
Conversation
Thanks for contributing to Ivy! 😊👏 |
Please review here @danielmunioz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Hey @AryanSharma21! Thanks for contributing! Yeah the tests seem to be passing locally no problem there, however it seems that the function arguments are a bit different from the ones used on the original implementation could you please modify the arguments so that they match the original ones? Other than that the PR looks in good shape! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Hello @danielmunioz , thanks for pointing this out. I have removed the dtype argument here and re-tested, Is there anything else that needs to be fixed please let me know. |
Hey! @AryanSharma21! Yeah, looks good now, just a minor extra letter on Other than that, the PR looks good to me! Thanks for contributing :) |
Co-authored-by: Aryan Sharma <[email protected]> Co-authored-by: danielmunioz <[email protected]>
Co-authored-by: Aryan Sharma <[email protected]> Co-authored-by: danielmunioz <[email protected]>
close #23118
Local env Function test result:
Local env lint formatting test: