Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented Igamma #21393

Merged
merged 3 commits into from
Aug 17, 2023
Merged

implemented Igamma #21393

merged 3 commits into from
Aug 17, 2023

Conversation

ShoaibMajidDar
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ShoaibMajidDar
Copy link
Contributor Author

Close #21392

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Aug 7, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@ShoaibMajidDar
Copy link
Contributor Author

hi @hmahmood24 can you please review this PR

Copy link
Contributor

@hmahmood24 hmahmood24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShoaibMajidDar, apologies for they delay and thanks for the PR. Everything looks good to me. Just suggested a minor change. Thanks!

Comment on lines 962 to 964
@to_ivy_arrays_and_back
def Igamma(*, a, x, name=None):
return ivy.igamma(a, x=x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, you need to map this to the alias in the math submodule like so:

to_ivy_arrays_and_back(
    (map_raw_ops_alias(tf_frontend.math.igamma))
)

@ShoaibMajidDar
Copy link
Contributor Author

Hi @hmahmood24 I have done the changes asked by you

@hmahmood24
Copy link
Contributor

Hi @hmahmood24 I have done the changes asked by you

Hi @ShoaibMajidDar, did you run your tests locally first? They are failing in the CI: https://github.com/unifyai/ivy/actions/runs/5874979109/job/15930549822?pr=21393. Can you fix those? Probably has to do with unsupported dtypes that need to be added

Copy link
Contributor

@hmahmood24 hmahmood24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to have the tests passing first in order to merge the PR

@ShoaibMajidDar
Copy link
Contributor Author

@hmahmood24 I have resolved the errors, please review the PR.

Copy link
Contributor

@hmahmood24 hmahmood24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShoaibMajidDar Everything looks good now. Thanks for the PR! 🚀

@hmahmood24 hmahmood24 merged commit 5a46a75 into ivy-llc:main Aug 17, 2023
255 of 266 checks passed
@hmahmood24 hmahmood24 linked an issue Aug 17, 2023 that may be closed by this pull request
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
@ShoaibMajidDar ShoaibMajidDar deleted the task2 branch August 20, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Igamma
3 participants