-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented Igamma #21393
implemented Igamma #21393
Conversation
Thanks for contributing to Ivy! 😊👏 |
Close #21392 |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
hi @hmahmood24 can you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ShoaibMajidDar, apologies for they delay and thanks for the PR. Everything looks good to me. Just suggested a minor change. Thanks!
@to_ivy_arrays_and_back | ||
def Igamma(*, a, x, name=None): | ||
return ivy.igamma(a, x=x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, you need to map this to the alias in the math
submodule like so:
to_ivy_arrays_and_back(
(map_raw_ops_alias(tf_frontend.math.igamma))
)
Hi @hmahmood24 I have done the changes asked by you |
Hi @ShoaibMajidDar, did you run your tests locally first? They are failing in the CI: https://github.com/unifyai/ivy/actions/runs/5874979109/job/15930549822?pr=21393. Can you fix those? Probably has to do with unsupported dtypes that need to be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to have the tests passing first in order to merge the PR
@hmahmood24 I have resolved the errors, please review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShoaibMajidDar Everything looks good now. Thanks for the PR! 🚀
Co-authored-by: hmahmood24 <[email protected]>
No description provided.