Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: trigger tests empty commit" Was an empty commit #21263

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented Aug 3, 2023

Reverts #21212

@fnhirwa fnhirwa merged commit fccec10 into master Aug 3, 2023
31 of 33 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@fnhirwa fnhirwa deleted the revert-21212-chore-trigger-tests branch August 3, 2023 19:55
@a0m0rajab
Copy link
Contributor

Thank you for reverting it! I was confused how it was merged tbh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants