feat: add cpu function #21255

Prajyot70 · 2023-08-03T17:06:04Z

github-actions · 2023-08-03T17:06:17Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

a0m0rajab · 2023-08-04T23:08:06Z

Hi Thank you for your effort, since this is a frontend function, you need to implement it in the frontend folder and add the related tests, to do that you need to read the documentation or check other examples,

The related docs:
https://unify.ai/docs/ivy/overview/contributing.html
https://unify.ai/docs/ivy/overview/contributing.html

Prajyot70 · 2023-08-10T18:15:01Z

Hi Thank you for your effort, since this is a frontend function, you need to implement it in the frontend folder and add the related tests, to do that you need to read the documentation or check other examples,

The related docs:
https://unify.ai/docs/ivy/overview/contributing.html
https://unify.ai/docs/ivy/overview/contributing.html

Hello,
Thank you for your review!
I have made the required changes as stated by you. please have a look at them and if there are any mistakes or corrections needed please let me know.
Thank You!

a0m0rajab

Thanks for adding the tests, but can you check the implementation of the function again? the location is not correct and you need to follow the examples in the guide it will direct you.

Prajyot70 · 2023-08-18T07:35:12Z

Thanks for adding the tests, but can you check the implementation of the function again? the location is not correct and you need to follow the examples in the guide it will direct you.

Hello,
Thank you for your review!
I figured out the correct location for both the function and the test this time but when i try to make changes in the place it shows the following error, even though I'm trying to make changes in my forked repository.
There was a error commiting your changes: A file with the same name already exists. Please choose a different name and try again.
If i change the name then the location gets changed automatically. Do you have any potential suggestions for this issue.
Thank You!

JPGoodale · 2023-08-27T21:39:14Z

Hi @Prajyot70 I believe that this function should be added to the tensor file in the torch frontend and the test to the corresponding test_tensor one. Also the @to_ivy_arrays_and_back decorator is currently at the top of the file rather than just above the function which it is decorating and you still have a call of your function and print statement of its result at the bottom of the file which should be removed before pushing.

Prajyot70 · 2023-09-02T17:35:17Z

Hi @Prajyot70 I believe that this function should be added to the tensor file in the torch frontend and the test to the corresponding test_tensor one. Also the @to_ivy_arrays_and_back decorator is currently at the top of the file rather than just above the function which it is decorating and you still have a call of your function and print statement of its result at the bottom of the file which should be removed before pushing.

Hello,
Thank you for your review and suggestions it helped a lot!
I have made the required changes as stated by you. please have a look at them
Thank You!

JPGoodale · 2023-09-02T23:32:45Z

Hi @Prajyot70, glad I could help. It looks like the to_cpu method which you are trying to call has yet to have been implemented, maybe try using ivy.to_device. Also there a few spelling issues and missing fields in your test function, please take a look at these as they will of course cause your tests to fail even if the function itself is correct.

Prajyot70 · 2023-09-09T19:30:12Z

Hi @Prajyot70, glad I could help. It looks like the to_cpu method which you are trying to call has yet to have been implemented, maybe try using ivy.to_device. Also there a few spelling issues and missing fields in your test function, please take a look at these as they will of course cause your tests to fail even if the function itself is correct.

Hello,
I've made the following changes in the pull request,

Changed method from 'to_cpu' to 'ivy.to_device'
Made changes in test according to function
Corrected the spelling issues and missing feilds in the tests

Please have a look at them and let me know your insights.
Thank You!

Prajyot70 · 2023-09-21T18:00:02Z

Hello,
I've made the following changes in the pull request,

Changed method from 'to_cpu' to 'ivy.to_device'

Made changes in test according to function

Corrected the spelling issues and missing feilds in the tests

Please have a look at them and let me know your insights.
Thank You!

Hello @JPGoodale ,
This is just a kind reminder to bring your attention to the quoted message which explains the changes made in the PR according to your suggestions and ivy's contribution guidelines.
Please have a look at it and let me know your insights.
Thank You!

NripeshN · 2023-12-04T08:56:08Z

Hey @Prajyot70,
Could you please solve the merge conflicts.

github-actions

PR Compliance Checks Passed!

Prajyot70 · 2023-12-12T13:01:13Z

Hello @NripeshN ,
At last only one test was failing, that is because of the inappropriate PR title. Now i have updated the PR title as specified by conventional commits organization.
Please have a look.
Thank You!

Prajyot70 · 2023-12-19T17:39:42Z

Hello @NripeshN ,
This is a kind reminder to please review the PR. Github actions bot has commented as checks passed.
Thank You!

NripeshN · 2023-12-19T17:45:30Z

Hey @Prajyot70
Could you please solve the merge conflicts. You can do this by merging with upsteam

Sarvesh-Kesharwani · 2023-12-28T07:57:00Z

Hi @Prajyot70
Please work on the changes suggested and let me know afterwords.
Thanks

ivy-seed · 2024-02-08T05:53:37Z

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

Sarvesh-Kesharwani · 2023-12-28T07:53:49Z

ivy/functional/frontends/torch/tensor.py

@@ -633,6 +633,16 @@ def acos_(self):
        self.ivy_array = self.acos().ivy_array
        return self

+    @to_ivy_arrays_and_back
+    def to_cpu(self):


Use correct name as mentioned in open issues list here: #3612 or here in original functions here https://pytorch.org/docs/stable/generated/torch.Tensor.cpu.html#torch.Tensor.cpu.

Sarvesh-Kesharwani · 2023-12-28T07:55:15Z

ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py

@@ -7831,6 +7837,55 @@ def test_torch_index_select(
    )


+#cpu
+@handle_frontend_method
+class TestTorchInstanceToCPU(unittest.TestCase):(


why have you implemented the test in this fashion, any reason?

If not, stick to the way other test functions are implemented.
Thanks

Sarvesh-Kesharwani · 2023-12-28T07:55:41Z

ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py

+if __name__ == "__main__":
+    unittest.main()
+


I think these lines are unnecessary.

Prajyot70 · 2024-02-17T17:25:03Z

Hello @Sarvesh-Kesharwani ,
Thank you for your review & apologies for the delay.
I'll work on the changes and will inform you soon.
Thank You !

Ishticode · 2024-03-04T13:08:33Z

I am closing this as there are many issues still there pointed out by @a0m0rajab @JPGoodale @Sarvesh-Kesharwani above. The requested changes are not made, the implementation has a different name than the actual torch method and the tests are chosen to be implemented differently than other examples. Please follow our Contributing page for further details. Thanks for the efforts all

cpu pytorch frontend

8178af7

ivy-seed assigned JPGoodale Aug 3, 2023

a0m0rajab mentioned this pull request Aug 4, 2023

Create cpu #21103

Closed

Prajyot70 added 3 commits August 9, 2023 23:59

Update cpu pytorch frontend

6257d55

Merge branch 'unifyai:master' into patch-2

628b7da

Create test_tensor

d8ce0bc

Rename cpu pytorch frontend to functional/frontend/torch/torch.py

265956b

ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 10, 2023

a0m0rajab reviewed Aug 11, 2023

View reviewed changes

Prajyot70 added 2 commits August 13, 2023 13:29

Delete torch.py

577e193

Create cpu

b4b7165

Prajyot70 added 5 commits September 1, 2023 23:30

Update tensor.py

1a298a4

Update test_tensor.py

7b8ae32

Update torch.py

4d72bc0

Delete ivy_tests/test_ivy/test_frontends/test_torch/test_tensor

db0c288

Delete ivy/functional/frontends/torch/torch.py

2f2ad38

Prajyot70 added 2 commits September 10, 2023 00:30

Update tensor.py

44688cc

Update test_tensor.py

b86109b

JPGoodale assigned NripeshN and unassigned JPGoodale Dec 3, 2023

github-actions bot reviewed Dec 6, 2023

View reviewed changes

🤖 Lint code

44812e5

Prajyot70 changed the title ~~cpu pytorch frontend~~ feat: add cpu function Dec 12, 2023

Prajyot70 changed the title ~~feat: add cpu function~~ feat : add cpu function Dec 21, 2023

Prajyot70 changed the title ~~feat : add cpu function~~ feat: add cpu function Dec 21, 2023

Prajyot70 and others added 9 commits December 21, 2023 23:40

Merge branch 'main' into patch-2

f568a40

Update tensor.py

d8e747e

Update test_tensor.py

1dcb9ed

🤖 Lint code

2747f29

Update test_tensor.py

61d3859

🤖 Lint code

bc18489

Update test_tensor.py

1e765d8

🤖 Lint code

602cc21

Update test_tensor.py

6193216

ivy-leaves unassigned NripeshN Dec 23, 2023

ivy-seed assigned Sarvesh-Kesharwani Dec 23, 2023

Prajyot70 and others added 4 commits December 27, 2023 14:25

Update test_tensor.py

311532b

🤖 Lint code

bfa1299

Update test_tensor.py

aecd4f9

🤖 Lint code

4befcf7

ivy-seed added the Stale label Feb 8, 2024

Sarvesh-Kesharwani suggested changes Feb 10, 2024

View reviewed changes

Ishticode closed this Mar 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add cpu function #21255

feat: add cpu function #21255

Prajyot70 commented Aug 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023

a0m0rajab commented Aug 4, 2023

Prajyot70 commented Aug 10, 2023

a0m0rajab left a comment

Prajyot70 commented Aug 18, 2023

JPGoodale commented Aug 27, 2023

Prajyot70 commented Sep 2, 2023

JPGoodale commented Sep 2, 2023

Prajyot70 commented Sep 9, 2023 •

edited

Loading

Prajyot70 commented Sep 21, 2023 •

edited

Loading

NripeshN commented Dec 4, 2023

github-actions bot left a comment •

edited

Loading

Prajyot70 commented Dec 12, 2023

Prajyot70 commented Dec 19, 2023

NripeshN commented Dec 19, 2023 •

edited

Loading

Sarvesh-Kesharwani commented Dec 28, 2023

ivy-seed commented Feb 8, 2024

Sarvesh-Kesharwani Dec 28, 2023

Sarvesh-Kesharwani Dec 28, 2023

Sarvesh-Kesharwani Dec 28, 2023

Sarvesh-Kesharwani Dec 28, 2023

Prajyot70 commented Feb 17, 2024

Ishticode commented Mar 4, 2024 •

edited

Loading

feat: add cpu function #21255

feat: add cpu function #21255

Conversation

Prajyot70 commented Aug 3, 2023 • edited Loading

github-actions bot commented Aug 3, 2023

a0m0rajab commented Aug 4, 2023

Prajyot70 commented Aug 10, 2023

a0m0rajab left a comment

Choose a reason for hiding this comment

Prajyot70 commented Aug 18, 2023

JPGoodale commented Aug 27, 2023

Prajyot70 commented Sep 2, 2023

JPGoodale commented Sep 2, 2023

Prajyot70 commented Sep 9, 2023 • edited Loading

Prajyot70 commented Sep 21, 2023 • edited Loading

NripeshN commented Dec 4, 2023

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

Prajyot70 commented Dec 12, 2023

Prajyot70 commented Dec 19, 2023

NripeshN commented Dec 19, 2023 • edited Loading

Sarvesh-Kesharwani commented Dec 28, 2023

ivy-seed commented Feb 8, 2024

Sarvesh-Kesharwani Dec 28, 2023

Choose a reason for hiding this comment

Sarvesh-Kesharwani Dec 28, 2023

Choose a reason for hiding this comment

Sarvesh-Kesharwani Dec 28, 2023

Choose a reason for hiding this comment

Sarvesh-Kesharwani Dec 28, 2023

Choose a reason for hiding this comment

Prajyot70 commented Feb 17, 2024

Ishticode commented Mar 4, 2024 • edited Loading

Prajyot70 commented Aug 3, 2023 •

edited

Loading

Prajyot70 commented Sep 9, 2023 •

edited

Loading

Prajyot70 commented Sep 21, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

NripeshN commented Dec 19, 2023 •

edited

Loading

Ishticode commented Mar 4, 2024 •

edited

Loading