Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Block routine manipulation for Numpy #21249

Closed
wants to merge 14 commits into from
Closed

Added Block routine manipulation for Numpy #21249

wants to merge 14 commits into from

Conversation

Nwaamaka-Iduwe
Copy link
Contributor

Issue #19845

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Aug 3, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@AryanSharma21 AryanSharma21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Nwaamaka-Iduwe , Can you please re check the file that you have deleted here ?

@Nwaamaka-Iduwe
Copy link
Contributor Author

Hey, @Nwaamaka-Iduwe , Can you please re check the file that you have deleted here ?

Hi Aryan, I don't understand what you mean?

@V-G-spec
Copy link
Contributor

V-G-spec commented Aug 3, 2023

@Nwaamaka-Iduwe I have no idea who Aryan Sharma is, let me try and get to the bottom of this 😅
Meanwhile, can you take a look at the failing tests? Thanks!

@Nwaamaka-Iduwe
Copy link
Contributor Author

@Nwaamaka-Iduwe I have no idea who Aryan Sharma is, let me try and get to the bottom of this 😅 Meanwhile, can you take a look at the failing tests? Thanks!

Hi, I noticed that a majority of the fails are coming from commits I made on a different patch days ago. I was working on an issue two days ago but was told it doesn't exist on the list and so I had to delete it. I'm not sure why its coming up on this patch too cause I took the code out. Do you have any suggestions? Perhaps I should delete that fork and do a new one to work with.

@AryanSharma21
Copy link
Contributor

@Nwaamaka-Iduwe I have no idea who Aryan Sharma is, let me try and get to the bottom of this 😅 Meanwhile, can you take a look at the failing tests? Thanks!

hello guys 😊, I am just a new learner trying to contribute and learn from people's PRs. Its just that I looked at commited changes on this PR and files changed I saw the file
ivy_tests/test_ivy/test_frontends/test_numpy/test_manipulation_routines/test_changing_array_shape.py
the code was entirely deleted so I wasn't able to understand how it serves the function.

I am sorry if I caused any inconvenience 😊

@Nwaamaka-Iduwe Nwaamaka-Iduwe closed this by deleting the head repository Aug 4, 2023
@V-G-spec
Copy link
Contributor

V-G-spec commented Aug 7, 2023

@Nwaamaka-Iduwe I have no idea who Aryan Sharma is, let me try and get to the bottom of this 😅 Meanwhile, can you take a look at the failing tests? Thanks!

hello guys 😊, I am just a new learner trying to contribute and learn from people's PRs. Its just that I looked at commited changes on this PR and files changed I saw the file ivy_tests/test_ivy/test_frontends/test_numpy/test_manipulation_routines/test_changing_array_shape.py the code was entirely deleted so I wasn't able to understand how it serves the function.

I am sorry if I caused any inconvenience 😊

Hey @AryanSharma21, no worries at all! I'm happy to see you are trying to learn and contribute in a meaningful way. Apologies for my message earlier. It is completely understandable to go through the codebase and have doubts. Perhaps next time, you can make your position clear to the contributor (who might also be new to the open-source contribution world) and avoid any confusion.
Once again, thanks for initiating some productive discussions surrounding the PR! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants