-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refractor: footer links - column 4 - rel attribute #740
base: main
Are you sure you want to change the base?
Conversation
Current changes don't compile, there's an error:
I'll also try to troubleshoot. |
Built with local Hugo, my bad. I will troubleshoot later with the proper build. |
Okay I have found the issue, it lies with custom parameters in the Hugo Menu. The output of Custom Hugo parameters for the menu were added in Hugo version 0.79.0. I will be adding one more commit that fixes the parameter definition. Otherwise this PR should just be held until the site updates to a newer Hugo version. |
@aaofyi OK understood, thanks for the info. I'll check if I can upgrade Hugo to latest version without braking anything on the site. |
If you update to Hugo This change is detailed in Hugo's docs: |
OK understood. Thanks for the heads up. |
PR type
What kind of change does this PR introduce?
PR checklist
Please check if your PR fulfills the following requirements:
Unsure if this requires configuration usage documentation.
What is the current behavior?
Currently iVPN has a link to mastodon but it lacks
rel="me"
, meaning iVPN does not appear verified on Mastodon.The iVPN site also does not include noopener or noferrer on external social links.
The changes detailed in the next section allow the
rel
to be customized withinconfig.toml
, allowing these problems to be addressed individually.What is the new behavior?
Now
footercolfour
links in theconfig.toml
can be configured to have arel
. If one does not exist, it will not add therel
definition at all. This accomplishes three tasks:Note in the
config.toml
file themastodon
definition includesme
. iVPN already includes the proper link (without theme
) on their site, but their Mastodon profile lacks verification. This modification would allow the site to automatically become verified on Mastodon with no further effort. Relevant links for this:Does this PR introduce a breaking change?
Other information