Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss28: Add and tidy up "About the IVOA" page #35

Merged
merged 6 commits into from
May 22, 2024
Merged

Iss28: Add and tidy up "About the IVOA" page #35

merged 6 commits into from
May 22, 2024

Conversation

alaity47
Copy link
Collaborator

@alaity47 alaity47 commented May 22, 2024 •
edited by JeremyMcCormick
Loading

Couple of notes:

  • Link to this page in the bottom menu needs to be updated (underscores instead of hyphens)
  • Depends on links to some other pages that arenʻt in there yet (/members, /about/member-contacts, /deployers) (This is fine for now.)

@JeremyMcCormick JeremyMcCormick changed the title Iss28 Iss28: Add and tidy up "About the IVOA" page May 22, 2024
@JeremyMcCormick
Copy link
Collaborator

Fixed sitemap link.

@JeremyMcCormick JeremyMcCormick self-requested a review May 22, 2024 07:14
JeremyMcCormick
JeremyMcCormick approved these changes May 22, 2024 •
edited
Loading
View reviewed changes
JeremyMcCormick
JeremyMcCormick requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few fixes:

I can fix these issues.

JeremyMcCormick
JeremyMcCormick approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still includes some broken links to other pages, but this will be fixed in the future.

@JeremyMcCormick JeremyMcCormick merged commit 5bb7914 into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyMcCormick JeremyMcCormick JeremyMcCormick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaity47 @JeremyMcCormick