Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist from repo #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zcei
Copy link
Contributor

@zcei zcei commented Apr 5, 2016

Dist files are only needed for pushing to npm.
In order to keep commit diffs as small as possible remove dist/index.js and add dist to .gitignore.
Adds .npmignore to not ignore dist folder while publishing.

Dist files are only needed for pushing to npm.
In order to keep commit diffs as small as possible
remove dist/index.js and add dist to gitignore.
@itaylor
Copy link
Owner

itaylor commented Apr 5, 2016

Let me think about this one. The thing I like about having dist checked in is that you can get the exact same code that is in NPM by checking out the repo.

@zcei
Copy link
Contributor Author

zcei commented Apr 5, 2016

How about providing a README section on how to build the code?

Or even some npm run build script.
Only drawback would be to include babel/babel-cli inside of the project, so we don't rely on them having the babel-cli installed. That's why I didn't include this approach here.

@zcei
Copy link
Contributor Author

zcei commented Apr 8, 2016

As this discussion came up at work today, here the sentence with which I argued it against my colleagues:

It's called git-scm - source control management. Your compiled/built code is an artifact, not actual source code

Just thought I drop this note here, so you get why I created the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants