Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spid backend acr selection #135

Merged
merged 5 commits into from
Mar 27, 2024
Merged

spid backend acr selection #135

merged 5 commits into from
Mar 27, 2024

Conversation

peppelinux
Copy link
Member

this PR resolves a pending issues we have with the acr selection in the response.

@peppelinux peppelinux requested a review from MdreW March 13, 2024 07:58
AlessiaVe
AlessiaVe suggested changes Mar 14, 2024
View reviewed changes
Copy link

@AlessiaVe AlessiaVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the code run correctly, the value of the issuer must be set:

issuer = authn_response.response.issuer.text.strip()

peppelinux
peppelinux commented Mar 14, 2024
View reviewed changes
example/backends/spidsaml2.py Outdated Show resolved Hide resolved
example/backends/spidsaml2.py Outdated Show resolved Hide resolved
@MdreW MdreW merged commit 44153eb into master Mar 27, 2024
2 of 3 checks passed
@MdreW MdreW mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MdreW MdreW MdreW approved these changes

@AlessiaVe AlessiaVe AlessiaVe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppelinux @MdreW @AlessiaVe