Fix #125 #127 #129 #130 #132 #133 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MdreW
commented
Feb 22, 2024
•
MdreW
commented
- fix Env configuration for yaml files don't support array type #133 - removed environment with list: !ENV tag support only string type
- fix Wrong environments in example/entrypoint.sh #132 - fix environment name in entrypoint.sh
- Fix Reorder docker-compose satosa environments #130 - Reorder satosa-saml2spid service environments in docker-compose.yml
- Fix HOSTNAME env override a useful system env #129 - Renamed HOSTNAME env in SATOSA_HOSTNAME
- Fix Missing default for KEYS_FOLDER environments #127 - Renamed KEYS_FOLDER env in SATOSA_KEYS_FOLDER and added ad default value
- Fix SATOSA_REQUESTED_ATTRIBUTES environment is not sufficent for all backends #125 - Splitted SATOSA_REQUESTED_ATTRIBUTES env in SATOSA_REQUESTED_SPID_ATTRIBUTES and SATOSA_REQUESTED_CIE_ATTRIBUTES
… default value.
…ED_SPID_ATTRIBUTES and SATOSA_REQUESTED_CIE_ATTRIBUTES
peppelinux
requested changes
Feb 22, 2024
| @@ -124,7 +124,7 @@ config: | |||
|
|
|||
| # this instantiate the attribute_consuming_service | |||
| required_attributes: ['spidCode', 'name', 'familyName', 'fiscalNumber', 'email'] | |||
| requested_attributes: !ENV SATOSA_REQUESTED_ATTRIBUTES | |||
| requested_attributes: !ENV SATOSA_REQUESTED_SPID_ATTRIBUTES | |||
There was a problem hiding this comment.
could you please set default values along with this ENV? (eg, :-default ...)
could you please provide in this PR the CIE attribute-maps in the example folder and use a default parameter that points there?
peppelinux
requested changes
Feb 23, 2024
Docker-compose/docker-compose.yml
Outdated
Comment on lines
107
to
108
| - SATOSA_REQUESTED_SPID_ATTRIBUTES=${SATOSA_REQUESTED_SPID_ATTRIBUTES:-[]} | ||
| - SATOSA_REQUESTED_CIE_ATTRIBUTES=${SATOSA_REQUESTED_CIE_ATTRIBUTES:-[]} |
There was a problem hiding this comment.
@MdreW could you please add default values, considering the conventional spid or cie sets?
peppelinux
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.