Maint/396 maintenance fix code scanning report issues (#504)

* added to string * removed clonable * removed usless null comparison * spotless * added lombok annotation
it-at-m · Nov 11, 2024 · b909e68 · b909e68
1 parent 8f2dad4
commit b909e68
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...ackend/src/main/java/de/muenchen/refarch/configuration/nfcconverter/NfcRequestFilter.java b/...ackend/src/main/java/de/muenchen/refarch/configuration/nfcconverter/NfcRequestFilter.java
@@ -85,7 +85,7 @@ protected void doFilterInternal(final HttpServletRequest request, final HttpServ
 
         final String contentType = request.getContentType();
         log.debug("ContentType for request with URI: \"{}\"", contentType);
-        if (contentTypes != null && contentTypes.contains(contentType)) {
+        if (contentTypes.contains(contentType)) {
             log.debug("Processing request {}.", request.getRequestURI());
             filterChain.doFilter(new NfcRequest(request, contentTypes), response);
         } else {

diff --git a/refarch-backend/src/main/java/de/muenchen/refarch/domain/BaseEntity.java b/refarch-backend/src/main/java/de/muenchen/refarch/domain/BaseEntity.java
@@ -20,7 +20,7 @@
 @Setter
 @ToString
 @EqualsAndHashCode
-public abstract class BaseEntity implements Cloneable, Serializable {
+public abstract class BaseEntity implements Serializable {
 
     @Serial
     private static final long serialVersionUID = 1L;
@@ -29,4 +29,5 @@ public abstract class BaseEntity implements Cloneable, Serializable {
     @Id
     @GeneratedValue(strategy = GenerationType.UUID)
     private UUID id;
+
 }
diff --git a/refarch-backend/src/main/java/de/muenchen/refarch/security/RequestResponseLoggingFilter.java b/refarch-backend/src/main/java/de/muenchen/refarch/security/RequestResponseLoggingFilter.java
@@ -11,6 +11,7 @@
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.List;
+import lombok.ToString;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.core.annotation.Order;
@@ -23,6 +24,7 @@
 @Component
 @Order(1)
 @Slf4j
+@ToString
 public class RequestResponseLoggingFilter implements Filter {
 
     private static final String REQUEST_LOGGING_MODE_ALL = "all";
@@ -84,5 +86,4 @@ private boolean checkForLogging(final HttpServletRequest httpServletRequest) {
                 || (REQUEST_LOGGING_MODE_CHANGING.equals(requestLoggingMode)
                         && CHANGING_METHODS.contains(httpServletRequest.getMethod()));
     }
-
 }