Skip to content

Commit

Permalink
Merge pull request #99 from isucon/feature/development-docker
Browse files Browse the repository at this point in the history
benchのビルド設定が間違っていた, Docker for Macだとこの設定だとビルドできなかった
  • Loading branch information
mackee authored Jun 24, 2022
2 parents dbf277d + 44ef552 commit 2ba8592
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
4 changes: 2 additions & 2 deletions development/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
.PHONY: install-initialdata init-mysql run-bench run-bench-noload

up/%:
docker compose -f docker-compose-$*.yml -f docker-compose-common.yml up -d
docker compose -f docker-compose-$*.yml -f docker-compose-common.yml up --build -d

down/%:
docker compose -f docker-compose-$*.yml -f docker-compose-common.yml down -d
docker compose -f docker-compose-$*.yml -f docker-compose-common.yml down

logs-webapp/%:
docker compose -f docker-compose-$*.yml -f docker-compose-common.yml logs -f webapp
Expand Down
6 changes: 2 additions & 4 deletions development/docker-compose-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ services:
restart: always

blackauth:
build:
context: ../
dockerfile: ./development/backend-go/Dockerfile
build: ./backend-go
ports:
- "3001:3001"
init: true
Expand All @@ -43,7 +41,7 @@ services:
- main.go

bench:
build: ../webapp
build: ./backend-go
stdin_open: true
tty: true
environment:
Expand Down
4 changes: 1 addition & 3 deletions development/docker-compose-go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ services:
webapp:
cpus: 1
mem_limit: 1g
build:
context: ../
dockerfile: ./development/backend-go/Dockerfile
build: ./backend-go
environment:
ISUCON_DB_HOST: mysql
ISUCON_DB_PORT: 3306
Expand Down

0 comments on commit 2ba8592

Please sign in to comment.