Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update slack invite link #4996

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Update slack invite link #4996

merged 1 commit into from
Sep 5, 2023

Conversation

hzxuzhonghu
Copy link
Member

No description provided.

@hzxuzhonghu hzxuzhonghu requested a review from a team as a code owner September 5, 2023 08:37
@istio-policy-bot
Copy link

😊 Welcome @hzxuzhonghu! This is either your first contribution to the Istio test-infra repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@hzxuzhonghu
Copy link
Member Author

@kfaseela @craigbox

@hzxuzhonghu
Copy link
Member Author

Can we contact to slack to make it not expire

kfaseela
kfaseela approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@kfaseela kfaseela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hzxuzhonghu !

@istio-testing istio-testing merged commit 5b12bfe into master Sep 5, 2023
3 checks passed
@istio-testing istio-testing deleted the hzxuzhonghu-patch-1 branch September 5, 2023 08:45
@craigbox
Copy link
Contributor

craigbox commented Sep 5, 2023

Can we contact to slack to make it not expire

Apparently!

@kfaseela
Copy link
Member

kfaseela commented Sep 5, 2023

Can we contact to slack to make it not expire

We would need a paid version, which CNCF provides now? I think the migration was already in plan @craigbox ?

@hzxuzhonghu
Copy link
Member Author

Migrate to cncf channel? If yes, i donot feel that is friendly, we will lose large number of members

@kfaseela
Copy link
Member

kfaseela commented Sep 5, 2023

Migrate to cncf channel? If yes, i donot feel that is friendly, we will lose large number of members

Looks like @craigbox is suggesting a tip above, may be we should try :)

@craigbox
Copy link
Contributor

craigbox commented Sep 5, 2023

Migrate to cncf channel?

steering opinion remains "no"

@ericvn
Copy link
Contributor

ericvn commented Sep 5, 2023

I thought moving to CNCF left us with a single channel (which we have there today). We lose all ability to have things like release/wg/committee channels, etc.

@kfaseela kfaseela mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfaseela kfaseela kfaseela approved these changes

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hzxuzhonghu @istio-policy-bot @craigbox @kfaseela @ericvn @istio-testing