Add icons and onclick event handler to Navbar components #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isosphere
reviewed
Sep 2, 2024
isosphere
approved these changes
Sep 2, 2024
| onclick={props.onclick.clone()} | ||
| > | ||
| if let Some(icon) = props.icon { | ||
| {icon}{" "} |
There was a problem hiding this comment.
What's with the quoted space character?
There was a problem hiding this comment.
I'd done that to provide a little bit of extra space between the icon an the text.
Without the space, it looks like this:
I've also tried using the icon link helper, but that looks the same.
I tried switching build::bootstrap_icons() to use the same <svg class=...><use ...> syntax as the examples on that page:
sorted_icons.insert(lower_kebab_case, format!(
" pub const {upper_snake_case}: BI = BI(\"<svg class=\\\"bi\\\" aria-hidden=\\\"true\\\"><use xlink:href=\\\"#{lower_kebab_case}\\\"></use></svg>\");\n"
));...but it looks like that Bootstrap Icons' SVG sprite sheet needs either embedding or re-hosting on the same domain to work correctly... so that's entirely broken:
…xample. Misc changes: * `NavDropdownItemProps`: make `url` an `Option`, like `NavItemProperties`. * `NavDropdownItemProps`: don't implement `Eq` (incompatible with `Callback`). * Trim trailing whitespace characters from end-of-line.
micolous
force-pushed
the
navbar-icon-events
branch
from
090968b
to
75940b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add icons and
onclickevent handler to Navbar components.This lets you use a Navbar to trigger other functions in the app.
I've added these to the
basicsexample as well:Clicking them logs the event to the debug console, like the
formsexample does.Misc changes:
NavDropdownItemProps: makeurlanOption, likeNavItemProperties::url. Yew automatically converts existing usages.NavDropdownItemProps: don't implementEq, which is incompatible withCallback.basicsexample:Accordian->Accordionnavbar.rs(which unfortunately made things a bit noisy)