Support routing to start below a subdirectory on the server #800
Conversation
|
This is a great feature and would come in handy when packages create its own IR routes. If I understand your PR correctly, there's some references to a |
|
Yeah, can we try to use the mount feature? |
|
Hi, I'd love to try it, but how exactly is it supposed to work? I didn't see any reference in the "old" docs nor in the guide? And it would also be nice to know how mounts are supposed to work, are they meant to a) plug together applications from multiple routes for one bigger application, or c) both? |
|
@DanielDornhardt, will come back to this on next release. Definitely a use case that should be supported. Just need to get this release ready for v1 and then get to the next batch of features. I'd like to spend more time looking at your implementation. For your question above: It's meant to say, this handler or function will get called for any url after a certain point. So if you mount a handler at /some/mount/point then it will handle /some/mount/point/a and /some/mount/point/a/b. Might not completely address this use case. I also removed the Router.use function for now until we hammer it out a little more. |
|
Hi, thanks for the feedback. My "implementation" was a simple fix for the old, pre-refactoring branch... So I am not sure if it still applies to the new Iron-Router. But yes, I think this should be supported. I am going to watch the eventedmind - IronRouter - tutorial one of these days, and maybe after that I'll be able to contribute a bit more. I also think that there might be another valuable aspect to this: The problem of "composability" of different packages... eg. Things like forums, admin or blog packages... right now it seems to me that the only simple option for adding packages with "pages" to an app is to use hard-coded routes, eg. the blog package, which uses /blog/ by default. In other systems (actually I am only familiar with this feature from Django, but it feels so intuitive and logical), it's possible to add a set of Routes / a routing configuration below another route. So the user could be allowed to mount the /blog/ package wherever he wanted. Below root, if he would like to, or maybe at /personal/blog . I am not sure how and where this could be added with the router package, as it would probably imply having multiple Router - objects, with one being attached to a route of the other... and the Router seems to have a kind of Singleton-ish / static role at the moment. But I still thing that'd be a great feature to provide to allow users to allow more turnkey app packages. https://docs.djangoproject.com/en/1.7/topics/http/urls/#including-other-urlconfs |
|
Hey @DanielDornhardt, Thanks for the link. That's helpful. Being able to mount routes or even a completely new router should be supported. |
|
Hello, I finally got around to update the project I needed this for to IronRouter 1.0+ ... unfortunately the patches I did for the old branch didn't work anymore, so I re-did the "incorporation of the ROOT_URL subdirectory" - fix. I created this pull request for Iron.Url: iron-meteor/iron-url#13 - and for IronRouter, basically only the Iron.Url - dependency would need to reference the newer Iron.Url - version: https://github.com/DanielDornhardt/iron-router-2/compare/incorporateMeteorROOT_URLSetting?expand=1 I hope this makes it into Iron-Router, thanks and best wishes! PS: It'd be great to have a more clear overview over the IronRouter - Stack / Middleware / Layer - stack, but I didn't really have the time to get into it, are there some specs / is there some introduction to it? |
|
I reopen this here again, sorry, because I felt like Iron-Url - Pull - Requests might not get noticed as quickly. I can't create a proper pull request for Iron-Router at the moment unfortunately, see the Iron.Url Pull request above for an explanation. The Iron-Router - updates probably would need to be done manually. Thanks and best wishes! And have a great weekend everybody too. :) |
|
Alright, please put this on hold for another day or two, I'm still ironing out some issues |
|
Ok, this is as good as it gets for now from my side: iron-meteor/iron-url#13
Sorry, this got a bit convoluted, I hope it's manageable. Best wishes! |
Hello,
i created this patch to be able to run apps in a subdirectories of a domain.
Eg. if I want to have an app on
mydomain.com/beta ,
it's possible to tell meteor that via a the ROOT_URL environment variable like this:
ROOT_URL="http://mydomain.com/beta" mrt ,
but IronRouter didn't take that into account until now, meaning the URL mydomain.com/beta/hello would match the route "/beta/hello", instead of just "hello".
This means that one would have to either manually prepend the /subdirectory/on/the/server to each route, or invent some other scheme to dynamically create routes when the same app should be available ob different subdirectories on different servers for example.
Meteor provides a runtime variable, meteor_runtime_config.ROOT_URL_PATH_PREFIX , which contains the /subdirectory/on/the/server in which the app is running, both on the client and the server.
We therefore can use this variable to prepend it to created URLs in the router and remove it from the URLs when trying to match routes.
This then allows for multiple apps on different subdirectories.
Server side routes seem to work as well with this patch as Meteor takes into account the ROOT_URL_PATH_PREFIX when creating HTTP endpoints.
THE ONLY THING NOT SO NICE about this patch is that it will break existing routes containing the subdirectories in the routes.
So maybe this should be made configurable, or check against manually set ROOT_URL_PATH_PREFIXes manually set by logging a warning to the console? And maybe disable this functionality for these routes?
Please have a look at the patch, see if it makes sense, if I forgot anything obvious and if there's anything I could do to make it more palatable.
Thanks for the great work everybody and best wishes!
PS: I've submitted a pull request to CollectionFS too, if anyone needs to use that as well as IronRouter, check it out here: https://github.com/CollectionFS/Meteor-cfs-access-point/pull/8 or here: https://github.com/DanielDornhardt/Meteor-cfs-access-point/tree/supportSubdirectoriesOnDomain (at least until it's merged.)