Add php7-mbstring extension to fix composer installation #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this extension, running build.rb on OS-X fails with: Step 2 : RUN curl -sS https://getcomposer.org/installer | php ---> Running in b918100ad154 Some settings on your machine make Composer unable to work properly. Make sure that you fix the issues listed below and run this script again: The iconv OR mbstring extension is required and both are missing. Install either of them or recompile php without --disable-iconv
|
Perhaps this type of pull request makes no sense for the actual usage of iron/php? I was looking at it as a general minimal php setup. |
|
Is that required only on the build image or typically used in production? |
|
It seems to be required by composer. I guess you could install it temporarily, install composer temporarily, use composer to install all your php code and create autoload files, and then remove both the extension and composer itself? Obviously that would not work for such a generic image. I am not sure how exactly this php image is used within iron worker. For our own purposes we are building something much more customized anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this extension, running build.rb on OS-X fails with:
Step 2 : RUN curl -sS https://getcomposer.org/installer | php
---> Running in b918100ad154
Some settings on your machine make Composer unable to work properly.
Make sure that you fix the issues listed below and run this script again:
The iconv OR mbstring extension is required and both are missing.
Install either of them or recompile php without --disable-iconv