adds multisigAccount boolean to account status #5604
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signifies to the user that the account is a multisig account. This will be helpful in many usecases in the CLI and Node App.
hughy
reviewed
Oct 30, 2024
Comment on lines
+161
to
+163
| const isMultisigAccount = account.multisigKeys | ||
| ? isSignerMultisig(account.multisigKeys) | ||
| : false |
There was a problem hiding this comment.
Should we also set this to true if isHardwareSignerMultisig? In the future we may also want to indicate that those accounts are Ledger accounts, but they're also multisig accounts
It's less clear to me how we should handle coordinator accounts 🤔
There was a problem hiding this comment.
yeah i was thinking maybe we want a type field instead? but i think that might push into the domain of your work with jason
There was a problem hiding this comment.
What would the different values of type be? Something like this?
- signer
- view-only
- multisig-signer
- multisig-coordinator
- ledger
- multisig-ledger
We're planning on refactoring how the wallet manages multisig identities, but I don't think we'll be adding or removing any types of accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
signifies to the user that the account is a multisig account. This will be helpful in many usecases in the CLI and Node App.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.