Circuit struct serialization #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
circuit-struct-serialization
branch
4 times, most recently
from
bb76735
to
08b6536
Compare
andiflabs
requested changes
Oct 23, 2024
jowparks
force-pushed
the
circuit-struct-serialization
branch
3 times, most recently
from
de26437
to
b7aa626
Compare
jowparks
force-pushed
the
circuit-struct-serialization
branch
2 times, most recently
from
c72a34d
to
7cb1410
Compare
andiflabs
approved these changes
Oct 24, 2024
jowparks
force-pushed
the
circuit-struct-serialization
branch
from
7cb1410
to
d997ff1
Compare
jowparks
force-pushed
the
circuit-struct-serialization
branch
from
d997ff1
to
dfc403a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds circuit struct ser/de so that downstream consumers (ie oreowallet) can interact with these primitives directly.
ser/de used here currently for external proving service:
https://github.com/oreoslabs/oreowallet-mono/blob/developer/crates/prover/src/handlers.rs
Seemed reasonable to move this into
ironfish-zkpTesting Plan
tests pass
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.