unshields iron by crediting account balance #5279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of sending public iron to the user account as part of the evm transaction credits the account balance in the state trie directly credits balance before executing transaction so that unshielded balance can be used to pay gas updates fixtures to include evm transactions when computing transaction fees for minersFee
hughy
force-pushed
the
wip/hughy/unshield-iron-credit-balance
branch
from
79e5e3e
to
6ab24c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
instead of sending public iron to the user account as part of the evm transaction credits the account balance in the state trie directly
credits balance before executing transaction so that unshielded balance can be used to pay gas
updates fixtures to include evm transactions when computing transaction fees for minersFee
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.