Update remaining artifact github actions to v4 #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
approved these changes
Jun 25, 2024
hughy
approved these changes
Jun 25, 2024
hughy
pushed a commit
that referenced
this pull request
Jul 8, 2024
patnir
added a commit
that referenced
this pull request
Aug 1, 2024
* Update remaining artifact github actions to v4 (#5072) * stops scanState meter on scan completion (#5108) when started the Meter class sets an interval to update its underlying arrays. if the meter is not stopped then this interval will keep running and keep the meter in the heap and leaks the meter memory. the WalletScanner creates a new ScanState and a new Meter for each scan. when the wallet is at the head of the chain this creates a new scan each time a block is added. fixes the memory leak by ensuring that the ScanState Meter is stopped when the scan completes and its interval function is cleared * version bump for v2.4.1 --------- Co-authored-by: jowparks <[email protected]> Co-authored-by: Rohan Jadvani <[email protected]> Co-authored-by: Daniel Cogan <[email protected]> Co-authored-by: Jason Spafford <[email protected]> Co-authored-by: Derek Guenther <[email protected]> Co-authored-by: Hugh Cunningham <[email protected]> Co-authored-by: mat-if <[email protected]> Co-authored-by: Hugh Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These jobs were still using v3, which is incompatible with v4 internally even though we didn't use any of the external stuff that changed.
https://github.com/iron-fish/ironfish/actions/runs/9653954995
Testing Plan
Documentation
N/A
Breaking Change
N/A