removes hash from account createdAt #5044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Jun 18, 2024
ironfish/src/rpc/routes/wallet/multisig/createTrustedDealerKeyPackage.ts
Outdated
Show resolved
Hide resolved
sets createdAt sequence to 'head.sequence - confirmations' to mitigate issues with setting account createdAt around the time of a chain reorg. adds migrations 33 to migrate existing account.createdAt values to use the existing createdAt.sequence - confirmations removes unused function chainGetPreviousBlockHash
uses single number value instead of nesting sequence in object updates all account fixtures
hughy
force-pushed
the
feat/hughy/createdat-sequence
branch
from
4b7c12e
to
ab981cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sets createdAt sequence to 'head.sequence - confirmations' to mitigate issues with setting account createdAt around the time of a chain reorg.
adds migrations 33 to migrate existing account.createdAt values to use the existing createdAt.sequence - confirmations
removes unused function chainGetPreviousBlockHash
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.