STAGING -> MASTER #4935
Merged
STAGING -> MASTER #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resets account createdAt to null on all accounts if the 'full' option is set on requests to wallet/rescanAccount. this forces rescans for all accounts to start at the genesis block instead of beginning at the account birthday. adds '--full' flag to wallet:rescan command.
…4908) * Normalize confirm message in CLI in a helper function https://linear.app/if-labs/issue/IFL-2471/normalize-confirm-message-in-cli-in-a-helper-function * adds aborted messages
When calling `importAccount` with an `RpcAccountImport` and a non-undefined `name`, the `name` parameter used to be ignored. This is no longer the case: passing a non-undefined `name` now overrides the name of the `RpcAccountImport`.
Also add a few more tests for trusted dealer key generation (TDK)
Adds a -f flag to specify the account the transaction is being sent from The raw transaction input is not optional and can be entered using a long prompt
* feat(cli,ironfish): Add flag to override name in round3 * Rename to accountName * Rename cli flag to accountName
The ironfish-mpc and ironfish-phase2 projects are now hosted in this repository: https://github.com/iron-fish/ironfish-mpc
* select secret name from list in dkg commands if no secretName is passed via flags allow the user to select one of their existing names from a list in round1 allow users to create a new secret name from the list makes it easier for users to know which secret names they have and can use in the context of the dkg commands. allows users to start the dkg process without running the participant:create command first * removes option to create new secret during round1 identities must be shared with all participants before round1, so secret must be created before round1
the next step instruction refers to the dealer in trusted dealer keygen, so it doesn't always apply now that we support dkg
When importing a multisig account, participant identities are stored in two places: 1. the public key package (part of the account record in the walletdb) 2. on dedicated records in the walletdb The #2 records can sometimes get lost. This is the case currently of account rescans. Because there is no future development scheduled that will benefit from #2, it's easier to just ignore those records and instead rely only on the public key package.
…s are recorded correctly
…cipants (#4926) * renames wallet:multisig:participants to wallet:multisig:account:participants renames the command to make it clearer that the command will list all of the participant identities in the group for a given account and not all participant identities that the wallet has created maintains the old command name as a deprecated alias * removes alias
* renames secretName to participantName the term 'secretName' does not make it clear that the name should be the same as the one used with 'participant:create', that is, the name of a participant renames the flag and rpc parameter 'secretName' to 'participantName' across all dkg cli commands and rpc endpoints changes flag character from s to n. in round3, this also requires changing the 'accountName' flag character from n to a adds an alias 'name' for 'participantName' in all dkg commands * fixes lint * fixes round1 identity help text * fixes rebase errors * fixes stray usage of secretName in RPC validation
* updates text of identities prompts clarifies which participant identities are expected when prompting for a list of identities on the command line in 'commitment:create', 'dealer:create', and 'dkg:round1' * adds missing commas before 'separated by commas'
allows users to view details for a transaction without needing to use the REPL useful for situations where you have a serialized transaction, but don't know what's in it
hughy
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.