changes createSigningShare RPC to take an account name #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes the RPC to take an account name as a request parameter instead of a serialized keyPackage loads the account for the given name and asserts that it is a multisig signing account before using the keyPackage from that account this avoids passing a keyPackage, which contains a sensitive secret, from being passed through an RPC request
patnir
approved these changes
Feb 6, 2024
|
Closes IFL-2186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
changes the RPC to take an account name as a request parameter instead of a serialized keyPackage
loads the account for the given name and asserts that it is a multisig signing account before using the keyPackage from that account
this avoids passing a keyPackage, which contains a sensitive secret, from being passed through an RPC request
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.