adds multisig/aggregateSigningShares RPC #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takes a publicKeyPackage, an unsignedTransaction, a signingPackage for that transaction, and a list of signatureShares for that signingPackage uses UnsignedTransaction.signFrost to aggregate the signatureShares, sign the transaction, and produce a signed transaction returns a signed transaction serialized as hex
jowparks
reviewed
Feb 5, 2024
ironfish/src/rpc/clients/client.ts
Outdated
| @@ -821,6 +823,15 @@ export abstract class RpcClient { | |||
| }, | |||
| } | |||
| multisig = { | |||
| aggregateSignatureShares: ( | |||
There was a problem hiding this comment.
We should either rename this to match signFrost or rename signFrost to match this.
There was a problem hiding this comment.
Merging as is for now, we'll settle on naming in a followup
jowparks
changed the title
jowparks
approved these changes
Feb 5, 2024
hughy
commented
Feb 5, 2024
s/Signature/Signing/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
takes a publicKeyPackage, an unsignedTransaction, a signingPackage for that transaction, and a list of signatureShares for that signingPackage
uses UnsignedTransaction.signFrost to aggregate the signatureShares, sign the transaction, and produce a signed transaction
returns a signed transaction serialized as hex
Testing Plan
RPC integration test will be added in a followup PR
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.