STAGING -> MASTER #4626
Merged
STAGING -> MASTER #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use deterministic nonce generation from a seeded RNG in the future we will use deterministic nonces generated from transaction inputs (transaction data and participant identities) since we do not need to save the nonces between rounds we can discard them from the round one outputs and return only the signing commitments renames RoundOneSigningData to SigningCommitments
* adding valueToUnspentNoteHashes index * *getUnspentNotesSortedByValue * adding getUnspentNotesSortedByValue * removing previous unspent note function * adding migration * adding migration 30 * adding wallet db tests * test for addSpendsForAsset * testing unspent notes for a minted asset * updating fixture * removing extraneous test * changing language to reflect unspent notes * changing fee amount to create notes of different values * removing load sorted notes from wallet db * replacing get unspent notes on account * regenerate fixture and lint * consolidating unspent note add delete * regenerating fixtures for walletdb change * simplifying test * simplifying migration * passing reverse directly to unspent note hashes
* importing split secret in lib.rs * creating identifier list * converting bytes to hex * identifiers from u16 to string * change to for loop for identifier conversion * using hex key for pgk * removing proof_generation_key_to_bytes * unused import * removing unwrap for creating sapling key * building artifacts * removing ironfish frost dependency --------- Co-authored-by: Joe <[email protected]>
adds binding for 'UnsignedTransaction::signing_package' to create a siging package from participant signing commitments returns the SigningPackage serialized as a hex string the signing package is created from the signing commitments that each participant generates in round 1. the signing package is then used as an input for generating signature shares in round 2 and for aggregating signature shares
* intermediate commit: add test, and method with deserialization for keypackage stuff * adds `sign_frost` method which aggregates signature shares and signed UnsignedTransaction * review updates
adds napi decorator to generate TypeScript changes type of seed to u32 to support serialization from TypeScript changes return type to String
refactors logic for adding spends, outputs, mints, and burns into '_build' to produce a 'NativeTransaction' 'build' uses '_build' to produce a NativeTransaction then calls 'build' on the NativeTransaction to produce a serialized UnsignedTransaction the multisig signing flow will require an UnsignedTransaction for generating a signing package
* adds frost participant napi bindings implements ParticipantSecret and ParticipantIdentity to wrap the Secret and Identity types for participants defined in ironfish-frost uses 'random' as ParticipantSecret constructor because we haven't implemented ser/de for Secret serializes frost Identifier as a hex string rather than defining a napi type for Identifier * removes to/fromHex from ParticipantIdentity we can convert between Buffer and string serialization in TypeScript if necessary * fixes frost slow test * removes unused import * adds missing newline
* WIP adds integration test for multisig signing * randomly generating identifiers * exploses public key randomness unsigned transaction * rebase * using ParticipantSecret to generate the identifiers * fixture update * removing .only from test * reverts change to imports * running linter * fixing randomness typo * reusing miner spending key instead of generating new ones for each block * running linter --------- Co-authored-by: Hugh Cunningham <[email protected]>
Adds a new PrefixArrayEncoding that will ultimately replace the existing PrefixEncoding. The goal here is a slightly better syntax.
…r identifier/keypackage mapping (#4605)
These timeouts used to exist before I created the standardized testing suite.
implements 'serialize' and changes constructor to deserialize from buffer adds separate static 'random' method to generate random secret updates tests to use 'random' instead of constructor pins ironfish-frost dependency to 'main' branch from git repo in order to pick up latest changes
* chore: updates split secret location, also uses key based approach for identifier/keypackage mapping * add createTrustedDealerKeyPackage rpc
* adds test of simple transaction signing - creates ProposedTransaction - builds transaction to create UnsignedTransaction - signs transaction to create PostedTransaction - verifies transaction * replaces unwrap with expect in test_sign_simple
* Adds signingCommitment type and endpoitn * changing namespace to multisig * test creates signing commitment * Adding TODO We currently pass the seed field in the request body, but this is eventually going to be removed when we have deterministic nonces
* prevents the filestore from throwing an error when an empty file exists * adds test to confirm empty file works * removes comment * Clean up the test a little * Clean up FileStore.load() --------- Co-authored-by: Jason Spafford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.