Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ironfish rust for frost minimal #4519

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jowparks
Copy link
Contributor

@jowparks jowparks commented Jan 9, 2024

Summary

  1. Add ironfish-frost = { git = "https://github.com/iron-fish/ironfish-frost.git" }
  2. Update rust-toolchain.toml to channel='nightly' as minimal update is only available on nightly
  3. run cargo update -Z minimal-versions -p cpufeatures -p proc-macro2 -p serde
  4. revert change to rust-toolchain.toml
  5. cargo build success
  6. profit

Testing Plan

tests pass

proc-macro2 1.0.59 -> 1.0.76 vs 1.0.60

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@jowparks jowparks changed the base branch from master to staging January 9, 2024 19:30
@jowparks jowparks marked this pull request as ready for review January 9, 2024 20:54
@jowparks jowparks requested a review from a team as a code owner January 9, 2024 20:54
@jowparks jowparks merged commit e3d54ed into staging Jan 9, 2024
31 of 32 checks passed
@jowparks jowparks deleted the update-ironfish-rust-for-frost-minimal branch January 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants