Dont snapshot resolve after reject (#1964)

There is a simple issue here in that during an error, resolve() is
called after reject() is called. This is because 'close' is ALWAYS
called no matter what if the stream finishes, or there is an error.

You can verify this if you add console logs to the writer handlers in
the staging branch.

ironfish-cli/src/commands/chain/download.ts

@@ -149,13 +149,20 @@ export default class Download extends IronfishCommand {
       })
 
       await new Promise<void>((resolve, reject) => {
-        writer.on('error', (e) => {
+        const onWriterError = (e: unknown) => {
+          writer.removeListener('close', onWriterClose)
+          writer.removeListener('onWriterError', onWriterError)
           reject(e)
-        })
+        }
 
-        writer.on('close', () => {
+        const onWriterClose = () => {
+          writer.removeListener('close', onWriterClose)
+          writer.removeListener('onWriterError', onWriterError)
           resolve()
-        })
+        }
+
+        writer.on('error', onWriterError)
+        writer.on('close', onWriterClose)
 
         response.data.on('error', (e) => {
           writer.destroy(e)