move args to be above flags in wallet command definitions (#5259)

ironfish-cli/src/commands/wallet/address.ts

@@ -10,17 +10,17 @@ export class AddressCommand extends IronfishCommand {
 
   The address for an account is the accounts public key, see more here: https://ironfish.network/docs/whitepaper/5_account`
 
-  static flags = {
-    ...RemoteFlags,
-  }
-
   static args = {
     account: Args.string({
       required: false,
       description: 'Name of the account to get the address for',
     }),
   }
 
+  static flags = {
+    ...RemoteFlags,
+  }
+
   async start(): Promise<void> {
     const { args } = await this.parse(AddressCommand)
     const { account } = args

ironfish-cli/src/commands/wallet/assets.ts

@@ -25,6 +25,13 @@ const MIN_ASSET_NAME_COLUMN_WIDTH = ASSET_NAME_LENGTH / 2 + 1
 export class AssetsCommand extends IronfishCommand {
   static description = `Display the wallet's assets`
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account. DEPRECATED: use --account flag',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     ...TableFlags,
@@ -34,13 +41,6 @@ export class AssetsCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account. DEPRECATED: use --account flag',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(AssetsCommand)
     // TODO: remove account arg

ironfish-cli/src/commands/wallet/balance.ts

@@ -15,6 +15,13 @@ export class BalanceCommand extends IronfishCommand {
   Available to spend balance is your coins from transactions that have been mined on blocks on your main chain.\n\
   Balance is your coins from all of your transactions, even if they are on forks or not yet included as part of a mined block.'
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account to get balance for. DEPRECATED: use --account flag',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     account: Flags.string({
@@ -39,13 +46,6 @@ export class BalanceCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account to get balance for. DEPRECATED: use --account flag',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(BalanceCommand)
     // TODO: remove account arg

ironfish-cli/src/commands/wallet/balances.ts

@@ -13,6 +13,13 @@ type AssetBalancePairs = { asset: RpcAsset; balance: GetBalancesResponse['balanc
 export class BalancesCommand extends IronfishCommand {
   static description = `Display the account's balances for all assets`
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account to get balances for. DEPRECATED: use --account flag',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     ...TableFlags,
@@ -30,13 +37,6 @@ export class BalancesCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account to get balances for. DEPRECATED: use --account flag',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(BalancesCommand)
     const client = await this.connectRpc()

ironfish-cli/src/commands/wallet/export.ts

@@ -13,6 +13,13 @@ export class ExportCommand extends IronfishCommand {
   static description = `Export an account`
   static enableJsonFlag = true
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account to export',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     ...JsonFlags,
@@ -39,13 +46,6 @@ export class ExportCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account to export',
-    }),
-  }
-
   async start(): Promise<unknown> {
     const { flags, args } = await this.parse(ExportCommand)
     const { local, path: exportPath, viewonly: viewOnly } = flags

ironfish-cli/src/commands/wallet/import.ts

@@ -17,6 +17,13 @@ import { Ledger } from '../../utils/ledger'
 export class ImportCommand extends IronfishCommand {
   static description = `Import an account`
 
+  static args = {
+    blob: Args.string({
+      required: false,
+      description: 'The copy-pasted output of wallet:export; or, a raw spending key',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     rescan: Flags.boolean({
@@ -40,13 +47,6 @@ export class ImportCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    blob: Args.string({
-      required: false,
-      description: 'The copy-pasted output of wallet:export; or, a raw spending key',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(ImportCommand)
     const { blob } = args

ironfish-cli/src/commands/wallet/notes/index.ts

@@ -12,6 +12,13 @@ const { sort: _, ...tableFlags } = TableFlags
 export class NotesCommand extends IronfishCommand {
   static description = `Display the account notes`
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account to get notes for. DEPRECATED: use --account flag',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     ...tableFlags,
@@ -21,13 +28,6 @@ export class NotesCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account to get notes for. DEPRECATED: use --account flag',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(NotesCommand)
     // TODO: remove account arg

ironfish-cli/src/commands/wallet/reset.ts

@@ -10,6 +10,13 @@ import { confirmOrQuit } from '../../ui'
 export class ResetCommand extends IronfishCommand {
   static description = `Resets the transaction of an account but keeps all keys.`
 
+  static args = {
+    account: Args.string({
+      required: true,
+      description: 'Name of the account to reset',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     resetCreated: Flags.boolean({
@@ -26,13 +33,6 @@ export class ResetCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: true,
-      description: 'Name of the account to reset',
-    }),
-  }
-
   async start(): Promise<void> {
     const { args, flags } = await this.parse(ResetCommand)
     const { account } = args

ironfish-cli/src/commands/wallet/scanning/off.ts

@@ -8,17 +8,17 @@ import { RemoteFlags } from '../../../flags'
 export class ScanningOffCommand extends IronfishCommand {
   static description = `Turn off scanning for an account. The wallet will no longer scan the blockchain for new account transactions.`
 
-  static flags = {
-    ...RemoteFlags,
-  }
-
   static args = {
     account: Args.string({
       required: true,
       description: 'Name of the account to update',
     }),
   }
 
+  static flags = {
+    ...RemoteFlags,
+  }
+
   async start(): Promise<void> {
     const { args } = await this.parse(ScanningOffCommand)
     const { account } = args

ironfish-cli/src/commands/wallet/scanning/on.ts

@@ -8,17 +8,17 @@ import { RemoteFlags } from '../../../flags'
 export class ScanningOnCommand extends IronfishCommand {
   static description = `Turn on scanning for an account. Scanning is on by default. The wallet will scan the blockchain for new account transactions.`
 
-  static flags = {
-    ...RemoteFlags,
-  }
-
   static args = {
     account: Args.string({
       required: true,
       description: 'Name of the account to update',
     }),
   }
 
+  static flags = {
+    ...RemoteFlags,
+  }
+
   async start(): Promise<void> {
     const { args } = await this.parse(ScanningOnCommand)
     const { account } = args

ironfish-cli/src/commands/wallet/transactions.ts

@@ -22,6 +22,13 @@ const { sort: _, ...tableFlags } = TableFlags
 export class TransactionsCommand extends IronfishCommand {
   static description = `Display the account transactions`
 
+  static args = {
+    account: Args.string({
+      required: false,
+      description: 'Name of the account. DEPRECATED: use --account flag',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     ...tableFlags,
@@ -52,13 +59,6 @@ export class TransactionsCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    account: Args.string({
-      required: false,
-      description: 'Name of the account. DEPRECATED: use --account flag',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionsCommand)
     // TODO: remove account arg

ironfish-cli/src/commands/wallet/transactions/import.ts

@@ -11,6 +11,13 @@ export class TransactionsImportCommand extends IronfishCommand {
 
   static hiddenAliases = ['wallet:transaction:add', 'wallet:transaction:import']
 
+  static args = {
+    transaction: Args.string({
+      required: false,
+      description: 'The transaction in hex encoding',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     path: Flags.string({
@@ -23,13 +30,6 @@ export class TransactionsImportCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    transaction: Args.string({
-      required: false,
-      description: 'The transaction in hex encoding',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionsImportCommand)
     const { transaction: txArg } = args

ironfish-cli/src/commands/wallet/transactions/info.ts

@@ -26,14 +26,6 @@ export class TransactionInfoCommand extends IronfishCommand {
 
   static hiddenAliases = ['wallet:transaction']
 
-  static flags = {
-    ...RemoteFlags,
-    account: Flags.string({
-      char: 'a',
-      description: 'Name of the account to get transaction details for',
-    }),
-  }
-
   static args = {
     hash: Args.string({
       required: true,
@@ -45,6 +37,14 @@ export class TransactionInfoCommand extends IronfishCommand {
     }),
   }
 
+  static flags = {
+    ...RemoteFlags,
+    account: Flags.string({
+      char: 'a',
+      description: 'Name of the account to get transaction details for',
+    }),
+  }
+
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionInfoCommand)
     const { hash } = args

ironfish-cli/src/commands/wallet/transactions/post.ts

@@ -21,6 +21,12 @@ export class TransactionsPostCommand extends IronfishCommand {
 
   static hiddenAliases = ['wallet:post']
 
+  static args = {
+    transaction: Args.string({
+      description: 'The raw transaction in hex encoding',
+    }),
+  }
+
   static flags = {
     ...RemoteFlags,
     account: Flags.string({
@@ -40,12 +46,6 @@ export class TransactionsPostCommand extends IronfishCommand {
     }),
   }
 
-  static args = {
-    transaction: Args.string({
-      description: 'The raw transaction in hex encoding',
-    }),
-  }
-
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionsPostCommand)
     let transaction = args.transaction