fixes Ledger approval output in round3 (#5397)

ask to approve round3 on Ledger, but don't ask for approval/confirmation when retrieving keys or public package
iron-fish · Sep 19, 2024 · 6402314 · 6402314
1 parent c70dd29
commit 6402314
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/ironfish-cli/src/utils/ledger.ts b/ironfish-cli/src/utils/ledger.ts
@@ -210,6 +210,8 @@ export class Ledger {
       throw new Error('Connect to Ledger first')
     }
 
+    this.logger.log('Please approve the request on your ledger device.')
+
     return this.tryInstruction(
       this.app.dkgRound3Min(
         index,
@@ -241,8 +243,6 @@ export class Ledger {
       throw new Error(`No public address returned.`)
     }
 
-    this.logger.log('Please confirm the request on your ledger device.')
-
     const responseViewKey = await this.tryInstruction(
       this.app.dkgRetrieveKeys(IronfishKeys.ViewKey),
     )
@@ -273,8 +273,6 @@ export class Ledger {
       throw new Error('Connect to Ledger first')
     }
 
-    this.logger.log('Please approve the request on your ledger device.')
-
     const response = await this.tryInstruction(this.app.dkgGetPublicPackage())
 
     return response.publicPackage