Skip to content

Commit

Permalink
fixes Ledger approval output in round3
Browse files Browse the repository at this point in the history
ask to approve round3 on Ledger, but don't ask for approval/confirmation when
retrieving keys or public package
  • Loading branch information
hughy committed Sep 19, 2024
1 parent c70dd29 commit 4314911
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions ironfish-cli/src/utils/ledger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ export class Ledger {
throw new Error('Connect to Ledger first')
}

this.logger.log('Please approve the request on your ledger device.')

return this.tryInstruction(
this.app.dkgRound3Min(
index,
Expand Down Expand Up @@ -241,8 +243,6 @@ export class Ledger {
throw new Error(`No public address returned.`)
}

this.logger.log('Please confirm the request on your ledger device.')

const responseViewKey = await this.tryInstruction(
this.app.dkgRetrieveKeys(IronfishKeys.ViewKey),
)
Expand Down Expand Up @@ -273,8 +273,6 @@ export class Ledger {
throw new Error('Connect to Ledger first')
}

this.logger.log('Please approve the request on your ledger device.')

const response = await this.tryInstruction(this.app.dkgGetPublicPackage())

return response.publicPackage
Expand Down

0 comments on commit 4314911

Please sign in to comment.