Improve RPC client types for broadcastTransaction and isValidPublicAd…

…dress (#5356)

Also logs if the transaction is not accepted or broadcast when calling the CLI chain:broadcast command.

ironfish-cli/src/commands/chain/broadcast.ts

@@ -26,8 +26,20 @@ export class BroadcastCommand extends IronfishCommand {
     ux.action.start(`Broadcasting transaction`)
     const client = await this.connectRpc()
     const response = await client.chain.broadcastTransaction({ transaction })
-    if (response.content) {
+
+    if (response.content.accepted && response.content.broadcasted) {
       ux.action.stop(`Transaction broadcasted: ${response.content.hash}`)
+    } else {
+      ux.action.stop()
+      this.error(
+        `Transaction broadcast may have failed.${
+          !response.content.accepted ? ' Transaction was not accepted by the node.' : ''
+        }${
+          !response.content.broadcasted
+            ? ' Transaction was not broadcasted to the network.'
+            : ''
+        }`,
+      )
     }
   }
 }

ironfish/src/rpc/clients/client.ts

@@ -1013,7 +1013,7 @@ export abstract class RpcClient {
 
     isValidPublicAddress: (
       params: IsValidPublicAddressRequest,
-    ): Promise<RpcResponse<IsValidPublicAddressResponse>> => {
+    ): Promise<RpcResponseEnded<IsValidPublicAddressResponse>> => {
       return this.request<IsValidPublicAddressResponse>(
         `${ApiNamespace.chain}/isValidPublicAddress`,
         params,
@@ -1022,7 +1022,7 @@ export abstract class RpcClient {
 
     broadcastTransaction: (
       params: BroadcastTransactionRequest,
-    ): Promise<RpcResponse<BroadcastTransactionResponse>> => {
+    ): Promise<RpcResponseEnded<BroadcastTransactionResponse>> => {
       return this.request<BroadcastTransactionResponse>(
         `${ApiNamespace.chain}/broadcastTransaction`,
         params,