Merge pull request #221 from weichang-bianjie/dev

R4R:improve code about collect address only successful tx
irisnet · Jul 13, 2020 · 2a5d16e · 2a5d16e
2 parents 0ea8526 + 7cc42e8
commit 2a5d16e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/service/handler/account.go b/service/handler/account.go
@@ -9,8 +9,12 @@ import (
 	"encoding/json"
 )
 
-func saveNewAccount(tx document.CommonTx) {
+//when new address not found or the tx is not success,this address will  not be collected
+func saveNewAccount(tx *document.CommonTx) {
 	var accountModel document.Account
+	if document.TxStatusSuccess != tx.Status {
+		return
+	}
 	switch tx.Type {
 	case constant.TxTypeTransfer:
 		accountModel.Address = tx.To

diff --git a/service/handler/tx.go b/service/handler/tx.go
@@ -30,7 +30,7 @@ func HandleTx(block *types.Block) (error) {
 		//handleTokenFlow(blockWithTags, tx, &batch)
 
 		// save new account address
-		saveNewAccount(tx)
+		saveNewAccount(&tx)
 	}
 
 	if len(batch) > 0 {