Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to <= dispatch count regression checks. #19166

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions experimental/benchmarks/sdxl/benchmark_sdxl_rocm.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def test_sdxl_rocm_benchmark(
goldentime_rocm_unet,
"SDXL unet benchmark time should not regress",
)
check.equal(
check.less_equal(
unet_dispatch_count,
goldendispatch_rocm_unet,
"SDXL scheduled unet dispatch count should not regress",
Expand All @@ -546,7 +546,7 @@ def test_sdxl_rocm_benchmark(
goldentime_rocm_punet_int8_fp16,
"SDXL punet f16 benchmark time should not regress",
)
check.equal(
check.less_equal(
punet_int8_fp16_dispatch_count,
goldendispatch_rocm_punet_int8_fp16,
"SDXL punet f16 dispatch count should not regress",
Expand All @@ -561,7 +561,7 @@ def test_sdxl_rocm_benchmark(
goldentime_rocm_punet_int8_fp8,
"SDXL punet f8 benchmark time should not regress",
)
check.equal(
check.less_equal(
punet_int8_fp8_dispatch_count,
goldendispatch_rocm_punet_int8_fp8,
"SDXL punet f8 dispatch count should not regress",
Expand All @@ -576,7 +576,7 @@ def test_sdxl_rocm_benchmark(
goldentime_rocm_clip,
"SDXL prompt encoder benchmark time should not regress",
)
check.equal(
check.less_equal(
clip_dispatch_count,
goldendispatch_rocm_clip,
"SDXL prompt encoder dispatch count should not regress",
Expand All @@ -591,7 +591,7 @@ def test_sdxl_rocm_benchmark(
goldentime_rocm_vae,
"SDXL vae decode benchmark time should not regress",
)
check.equal(
check.less_equal(
vae_dispatch_count,
goldendispatch_rocm_vae,
"SDXL vae decode dispatch count should not regress",
Expand Down
Loading