Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Torch-MLIR to c26ca8b #19158

Closed

Conversation

vivekkhandelwal1
Copy link
Member

This commit bumps Torch-MLIR to llvm/torch-mlir@c26ca8b.

This commit bumps Torch-MLIR to llvm/torch-mlir@c26ca8b.

Signed-off-by: Vivek Khandelwal <[email protected]>
@vivekkhandelwal1 vivekkhandelwal1 marked this pull request as ready for review November 15, 2024 09:55
@vivekkhandelwal1
Copy link
Member Author

Hi @ScottTodd, I'm not able to understand this CI failure. I don't see any particular error message apart from some dispatch regression related error.

@zjgarvey
Copy link
Contributor

If I understand correctly, this is not a regression, but an improvement? Benchmark time is improved and there is one less dispatch.

@benvanik
Copy link
Collaborator

Do we really have an == check? Or is the printing just bad? Improvements shouldn't cause breakages and checks like this should be <=.

ERROR experimental/benchmarks/sdxl/benchmark_sdxl_rocm.py::test_sdxl_rocm_benchmark - check 1563 == 1564: SDXL punet f8 dispatch count should not regress

@zjgarvey
Copy link
Contributor

Do we really have an == check? Or is the printing just bad? Improvements shouldn't cause breakages and checks like this should be <=.

Yeah. It's an equal check:

check.equal(
punet_int8_fp8_dispatch_count,
goldendispatch_rocm_punet_int8_fp8,
"SDXL punet f8 dispatch count should not regress",
)

@benvanik
Copy link
Collaborator

benvanik commented Nov 15, 2024

We should fix that - a good way to make things less useful is to add noise and alias success and failure - at absolute minimum that should print a giant "CONGRATS YOU MADE THINGS BETTER! THIS IS NOT AN ERROR! WE JUST HAVE A CHANGE DETECTOR" banner :P I don't want change detectors in the repo, though. @saienduri please change the logic to be <= and only error if there's regressions.

@saienduri
Copy link
Collaborator

Yeah, I agree. I originally proposed to have <= checks, but was specifically requested to make that an equal check. The error message is misleading though. Sorry about that. Have a PR here #19166 :)

@zjgarvey
Copy link
Contributor

Closing. See #19168

@zjgarvey zjgarvey closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants