-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Torch-MLIR to c26ca8b #19158
Bump Torch-MLIR to c26ca8b #19158
Conversation
This commit bumps Torch-MLIR to llvm/torch-mlir@c26ca8b. Signed-off-by: Vivek Khandelwal <[email protected]>
Signed-off-by: Vivek Khandelwal <[email protected]>
Signed-off-by: Vivek Khandelwal <[email protected]>
Hi @ScottTodd, I'm not able to understand this CI failure. I don't see any particular error message apart from some dispatch regression related error. |
If I understand correctly, this is not a regression, but an improvement? Benchmark time is improved and there is one less dispatch. |
Do we really have an == check? Or is the printing just bad? Improvements shouldn't cause breakages and checks like this should be <=.
|
Yeah. It's an equal check: iree/experimental/benchmarks/sdxl/benchmark_sdxl_rocm.py Lines 564 to 568 in c80fa3b
|
We should fix that - a good way to make things less useful is to add noise and alias success and failure - at absolute minimum that should print a giant "CONGRATS YOU MADE THINGS BETTER! THIS IS NOT AN ERROR! WE JUST HAVE A CHANGE DETECTOR" banner :P I don't want change detectors in the repo, though. @saienduri please change the logic to be <= and only error if there's regressions. |
Yeah, I agree. I originally proposed to have <= checks, but was specifically requested to make that an equal check. The error message is misleading though. Sorry about that. Have a PR here #19166 :) |
Closing. See #19168 |
This commit bumps Torch-MLIR to llvm/torch-mlir@c26ca8b.