Add pattern to bubble expand through collapse #18341
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
force-pushed
the
expand_shapes
branch
6 times, most recently
from
daa5049
to
e3e5be0
Compare
8 tasks
IanWood1
force-pushed
the
expand_shapes
branch
2 times, most recently
from
b9ba438
to
0e68145
Compare
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pattern from upstream commit llvm/llvm-project@a95ad2d
About a week ago, this was causing regressions with int8 sdxl, but I'm now unable to repro locally.
#18424 addresses the compilation failures, but im still trying to reproduce the correctness issues with sdxl