[PACKAGE] fix: make function really use the default value (#18486)

I was wondering why the MacOs nightly packages where failing. Seems like this was the issue.
iree-org · Sep 12, 2024 · c7351e1 · c7351e1
1 parent 861695b
commit c7351e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/compiler/setup.py b/compiler/setup.py
@@ -218,10 +218,10 @@ def maybe_nuke_cmake_cache():
         f.write(expected_stamp_contents)
 
 
-def get_env_cmake_option(name: str, default_value: bool = False) -> str:
+def get_env_cmake_option(name: str, default_value: str = "OFF") -> str:
     svalue = os.getenv(name)
     if not svalue:
-        svalue = "ON" if default_value else "OFF"
+        svalue = default_value
     return f"-D{name}={svalue}"
 
 

diff --git a/runtime/setup.py b/runtime/setup.py
@@ -228,10 +228,10 @@ def maybe_nuke_cmake_cache(cmake_build_dir, cmake_install_dir):
         f.write(expected_stamp_contents)
 
 
-def get_env_cmake_option(name: str, default_value: bool = False) -> str:
+def get_env_cmake_option(name: str, default_value: str = "OFF") -> str:
     svalue = os.getenv(name)
     if not svalue:
-        svalue = "ON" if default_value else "OFF"
+        svalue = default_value
     return f"-D{name}={svalue}"