Add type inference #252
Add type inference #252
Conversation
harsh-nod
force-pushed
the
type_inference
branch
2 times, most recently
from
2b1bed9
to
097edb9
Compare
harsh-nod
requested review from
raikonenfnu,
Hardcode84,
martin-luecke and
erman-gurses
harsh-nod
force-pushed
the
type_inference
branch
from
097edb9
to
a606651
Compare
harsh-nod
force-pushed
the
type_inference
branch
2 times, most recently
from
e5846a5
to
1e98db2
Compare
This PR adds a type inference pass to wave. Previously, the types were infered by looking up types from neighbors resulting in inefficient type inference. Instead, we now introduce a pass that infers the types for all operators in the graph and the inferred type is then stored in the node. Signed-off-by: Harsh Menon <[email protected]>
harsh-nod
force-pushed
the
type_inference
branch
from
1e98db2
to
286c235
Compare
| Infer the type of this operator using the types | ||
| of its arguments. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
maybe we can raise NotImplemented here?
There was a problem hiding this comment.
Good question. So the idea is that most operators will implement infer_types except for Placeholders, etc. For those operators, since they already have a type, we want this to just pass through instead of throwing an error.
| @@ -336,7 +336,7 @@ def _expand_reduction( | |||
| # Add GetResult nodes for the corresponding dimensions | |||
| reduction.graph.inserting_after(reduction.fx_node) | |||
| new_node = GetResult(reduction.fx_node, len(new_output_args)) | |||
| new_node.add_to_graph(reduction.graph) | |||
| new_node.add_to_graph(reduction.graph, arg.type) | |||
There was a problem hiding this comment.
Just curious what/why is the regular GetResult get_infer_type not working for this case? Can we add a comment to explain a bit.
There was a problem hiding this comment.
Sure I can add that. The short summary is that it would require us to find the output node to get the right type since this is during expansion and the init_args have not been set yet. So since we have access to arg, we just use that instead.
Signed-off-by: Harsh Menon <[email protected]>
This PR adds a type inference pass to wave. Previously, the types were infered by looking up types from neighbors resulting in inefficient type inference.
Instead, we now introduce a pass that infers the types for all operators in the graph and the inferred type is then stores in the node. New nodes that are constructed in downstream passes are responsible for annotating types for the new operators.