feat: add logging http api #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/log-api
branch
from
315687d
to
3bb4ceb
Compare
aschmahmann
force-pushed
the
feat/log-api
branch
from
3bb4ceb
to
8aa1933
Compare
gammazero
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
This looks good for a simple API to set the log level for a single facility. Consider providing a way to set level for all facilities.
Here is an existing API that allows the user to specify multiple facilities and levels if that is interesting: https://github.com/ipni/storetheindex/blob/main/server/admin/config_handler.go#L18-L46
|
After some sync conversation:
Also, overriding requirements here due to the only test failure being in the new e2e tests that are sometimes failing in master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an HTTP API for logging so it can be dynamically modified at runtime, also adds an API for listing all logging subsystems.