feat: expose standalone download function #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows downloading binaries for more than one platform. We want to use this in ipfs-desktop, to download both amd64 and arm64 binaries required for building universal DMGs. Exposing download function here allows us to 1. leverage cached downloads, avoid fetching same arch twice 2. confirm download by checkign sha512
lidel
commented
May 16, 2024
| /** | ||
| * @param {string} [version] | ||
| * @param {string} [platform] | ||
| * @param {string} [arch] | ||
| * @param {string} [installPath] | ||
| */ | ||
| module.exports = async (version, platform, arch, installPath) => { | ||
| module.exports.downloadAndUpdateBin = async (version, platform, arch, installPath) => { |
There was a problem hiding this comment.
ℹ️ This funciton did download+link. Renamed to better describe what it really does.
There was a problem hiding this comment.
ℹ️ Had to do this to pass lint
There was a problem hiding this comment.
ℹ️ Added test for download function.
16 tasks
SgtPooki
approved these changes
May 16, 2024
Comment on lines
+5
to
+7
| const { download } = require('./download') | ||
|
|
||
| module.exports.download = download |
There was a problem hiding this comment.
do we want to expose the downloadAndUpdateBin as well?
There was a problem hiding this comment.
I think no, it is only meaningful in NPM's postinstall hook, there is no use case where end use would want to use it.
|
Merging so this ships with 0.29.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes manual
downloadfunction that allows downloading binaries for more than one platform in programmatic fashion.Use case: we want to use this in ipfs-desktop, to download both amd64 and arm64 binaries required for building universal DMGs (ipfs/ipfs-desktop#1856).
Exposing
downloadfunction here allows us to: