feat: reprovider warning and announce-on|off profiles #10524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/explitic-annouce-profiles
branch
3 times, most recently
from
0ea4eaa
to
e7fbb22
Compare
lidel
commented
Sep 27, 2024
| @@ -299,7 +299,7 @@ Map of HTTP headers to set on responses from the RPC (`/api/v0`) HTTP server. | |||
| Example: | |||
| ```json | |||
| { | |||
| "Foo": ["bar"] | |||
| "Foo": ["bar"] | |||
There was a problem hiding this comment.
ℹ️ replaced tabs with space in entire file for consistency
lidel
changed the title
moving reprovide on/off to separate profile to avoid footgun where node no longer announces to DHT + ipfs daemon check that prints warning on start if reprovide system is disabled
lidel
force-pushed
the
feat/explitic-annouce-profiles
branch
from
e7fbb22
to
7dab0d1
Compare
gammazero
approved these changes
Sep 30, 2024
This was referenced Oct 2, 2024
jaller94
reviewed
Oct 7, 2024
|
|
||
| > [!IMPORTANT] | ||
| > If you've ever applied the `lowpower` profile before, there is a high chance your node is not announcing to DHT anymore. | ||
| > If you have `Reprovider.Interval` set to `0` you may want to wet it to `22h` (or run `ipfs config profile apply announce-on`) to fix your system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This PR aims to fix footgun that is
lowpowerprofile + warn users who already sabotaged themselves by disabling reprovide system (not announcing to DHT).Details
Users running on raspberrypi or other "lowpower" server often sabotaged themselves by disabling announcements when applying poorly documented
lowpowerprofile (example).To make matters worse, we've been prominently hinting that user should enable this profile to save resources, we did that in examples and docs (example – i've hidden this footgun from our docs, but the harm is already done)
This PR moves announcement settings to a separate profile, removing the footgun from
lowpowerone + warns users who have it disabled (if it was intentional, user can ignore the message).TODO
lowprofileshould not impact announcementsipfs daemonshould print warning when node is online but reprovide system is turned off