fix(tray): 🩹 Fixes the context loaded async in the tray. #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Arora <[email protected]>
whizzzkid
commented
Aug 22, 2023
| @@ -33,7 +33,7 @@ | |||
| // "typeRoots": [], /* Specify multiple folders that act like `./node_modules/@types`. */ | |||
| "types": ["node", "./types/countly-sdk-nodejs"], /* Specify type package names to be included without being referenced in a source file. */ | |||
| // "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */ | |||
| // "resolveJsonModule": true, /* Enable importing .json files */ | |||
| "resolveJsonModule": true, /* Enable importing .json files */ | |||
There was a problem hiding this comment.
this was a simple fix to require('../../package.json') errors.
SgtPooki
requested changes
Aug 22, 2023
src/tray.js
Outdated
Comment on lines
163
to
171
| click: () => { runGarbageCollector(ctx) }, | ||
| enabled: false | ||
| }, | ||
| { type: 'separator' }, | ||
| { | ||
| id: 'moveRepositoryLocation', | ||
| label: i18n.t('moveRepositoryLocation'), | ||
| click: () => { moveRepositoryLocation() } | ||
| // @ts-ignore | ||
| click: () => { moveRepositoryLocation(ctx) } |
There was a problem hiding this comment.
This won't work because ctx is different now (need to use ctx.get('getIpfsd')). We should be able to use getCtx() in runGarbageCollector and moveRepositoryLocation, or simply pass the ctx methods required.
There was a problem hiding this comment.
oh, my bad, it seemed to work but mostly would've been buggy. I wonder what's a good way to test this 🤔
SgtPooki
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
@whizzzkid take a peek at these new changes when you get a chance, and then let's merge and release when you're good with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2577
In this PR:
v0.30.1TODO: Move this to better type-definitions to not run into this.