Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos in test hints #187

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: fix typos in test hints #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/path_gateway_ipns_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func TestGatewayIPNSPath(t *testing.T) {
Name: "GET for /ipns/name with valid V1+V2 signatures with V1-vs-V2 value mismatch MUST fail with 5XX",
Hint: `
Legacy V1 signatures in IPNS records are considered insecure and
got replaced with V2 that sings entire CBOR in the data field.
got replaced with V2 that signs entire CBOR in the data field.
Producing records with both V1 and V2 signatures is valid for
backward-compatibility, but validation logic requires V1 (legacy
protobuf fields) and V2 (CBOR in data field) to match. This means
Expand All @@ -73,7 +73,7 @@ func TestGatewayIPNSPath(t *testing.T) {
Name: "GET for /ipns/name with valid V2 and broken V1 signature succeeds",
Hint: `
Legacy V1 signatures in IPNS records are considered insecure and
got replaced with V2 that sings entire CBOR in the data field.
got replaced with V2 that signs entire CBOR in the data field.
Integrity of the record is protected by SignatureV2, V1 can be
ignored as long V1 values match V2 ones in CBOR.
More details in IPIP-428.
Expand All @@ -100,7 +100,7 @@ func TestGatewayIPNSPath(t *testing.T) {
Name: "GET for /ipns/name with valid V2-only signature succeeds",
Hint: `
Legacy V1 signatures in IPNS records are considered insecure and
got replaced with V2 that sings entire CBOR in the data field.
got replaced with V2 that signs entire CBOR in the data field.
Gateway MUST correctly resolve IPNS records without V1 fields.
More details in IPIP-428.
`,
Expand Down
Loading