Skip to content

Commit

Permalink
fix: correct p12 location
Browse files Browse the repository at this point in the history
  • Loading branch information
lidel committed Apr 9, 2024
1 parent 182d8eb commit a0c2ab9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- name: Secrets for signing
run: |
echo -n "${{ secrets.APPLE_CERTS_P12 }}" | base64 --decode > ~/.apple-certs.p12
echo -n "{{ secrets.APPLE_CERTS_PASS }}" > ~/.apple-certs-pass
echo -n "{{ secrets.APPLE_CERTS_PASS }}" > ~/.apple-certs.pass
- name: Secrets for notarization with rcodesign (new, wip)
if: false
run: |
Expand Down
4 changes: 3 additions & 1 deletion scripts/ci/sign-new-macos-releases.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ echo "::group::Sign and notarize the mac binaries"
(! test -d "$NEW_DIR") && continue
DIST_VERSION=$(basename "$NEW_DIR")
DIST_NAME=$(basename $(dirname "$NEW_DIR"))
# TODO: restore dists/kubo/build_matrix (only macos for now, for faster tests)
DIST_MAC_ARCHS=$(gawk '{ print $2; }' <(grep darwin "./dists/${DIST_NAME}/build_matrix"))
for arch in $DIST_MAC_ARCHS; do
# create destination dir matching .tar.gz structure
Expand All @@ -40,9 +41,10 @@ echo "::group::Sign and notarize the mac binaries"
ls -hl "${file}"

echo "-> Signing ${file}"

# TODO: we can use rcodesign if we ever swithc away from macos runner
rcodesign sign \
--p12-file ~/.apple-certs --p12-password-file ~/.apple-certs-pass \
--p12-file ~/.apple-certs.p12 --p12-password-file ~/.apple-certs.pass \
--code-signature-flags runtime --for-notarization \
"${file}"

Expand Down

0 comments on commit a0c2ab9

Please sign in to comment.