Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bitswap client does not need ProviderQueryManager #676

Merged
merged 3 commits into from
Oct 15, 2024
Merged

refactor: bitswap client does not need ProviderQueryManager #676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08ae90e
btswap client does not need ProviderQueryManager
gammazero Sep 30, 2024
f3081a3
Merge branch 'main' into bitswap-client-no-pqm
gammazero Oct 3, 2024
2143247
Merge branch 'main' into bitswap-client-no-pqm
gammazero Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions bitswap/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ func New(parent context.Context, network bsnet.BitSwapNetwork, bstore blockstore
network: network,
process: px,
pm: pm,
pqm: pqm,
sm: sm,
sim: sim,
notif: notif,
Expand All @@ -184,7 +183,7 @@ func New(parent context.Context, network bsnet.BitSwapNetwork, bstore blockstore
option(bs)
}

bs.pqm.Startup()
pqm.Startup()

// bind the context and process.
// do it over here to avoid closing before all setup is done.
Expand All @@ -203,9 +202,6 @@ func New(parent context.Context, network bsnet.BitSwapNetwork, bstore blockstore
type Client struct {
pm *bspm.PeerManager

// the provider query manager manages requests to find providers
pqm *bspqm.ProviderQueryManager

// network delivers messages on behalf of the session
network bsnet.BitSwapNetwork

Expand Down