fix: use pathjoin to prevent unexpected separator bugs

ipfs · Oct 1, 2024 · 838a363 · 838a363
1 parent e734e77
commit 838a363
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/routing/http/client/client.go b/routing/http/client/client.go
@@ -9,6 +9,7 @@ import (
 	"io"
 	"mime"
 	"net/http"
+	"path"
 	"sort"
 	"strings"
 	"time"
@@ -222,7 +223,7 @@ func (c *Client) FindProviders(ctx context.Context, key cid.Cid) (providers iter
 	// TODO test measurements
 	m := newMeasurement("FindProviders")
 
-	url := fmt.Sprintf("%s/routing/v1/providers/%s", c.baseURL, key.String())
+	url := path.Join(c.baseURL, "routing/v1/providers", key.String())
 	url = filters.AddFiltersToURL(url, c.protocolFilter, c.addrFilter)
 
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
@@ -400,7 +401,7 @@ func (c *Client) provideSignedBitswapRecord(ctx context.Context, bswp *types.Wri
 func (c *Client) FindPeers(ctx context.Context, pid peer.ID) (peers iter.ResultIter[*types.PeerRecord], err error) {
 	m := newMeasurement("FindPeers")
 
-	url := fmt.Sprintf("%s/routing/v1/peers/%s", c.baseURL, peer.ToCid(pid).String())
+	url := path.Join(c.baseURL, "routing/v1/peers", peer.ToCid(pid).String())
 	url = filters.AddFiltersToURL(url, c.protocolFilter, c.addrFilter)
 
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)